Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang version for autoscaler repo #5626

Merged

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Oct 28, 2019

This is likely making unit fails here openshift/kubernetes-autoscaler#120
due to https://golang.org/doc/go1.12#library

# k8s.io/autoscaler/cluster-autoscaler/vendor/k8s.io/component-base/cli/flag
cluster-autoscaler/vendor/k8s.io/component-base/cli/flag/ciphersuites_flag.go:80:18: undefined: tls.VersionTLS13
[ERROR] PID 17: hack/test-go.sh:190: `go test -i ${gotest_flags} ${test_packages}` exited with status 2.
[INFO]          Stack Trace:
[INFO]            1: hack/test-go.sh:190: `go test -i ${gotest_flags} ${test_packages}`
[INFO]   Exiting with code 2.
[ERROR] hack/test-go.sh exited with code 2 after 00h 01m 09s
sh-4.2$

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@enxebre
Copy link
Member Author

enxebre commented Oct 29, 2019

/retest
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019
@openshift-ci-robot
Copy link
Contributor

@enxebre: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/kubernetes-autoscaler/release-4.4/unit df1cbea link /test pj-rehearse
ci/rehearse/openshift/kubernetes-autoscaler/release-4.3/unit df1cbea link /test pj-rehearse
ci/rehearse/openshift/kubernetes-autoscaler/master/unit df1cbea link /test pj-rehearse
ci/prow/pj-rehearse df1cbea link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spangenberg
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, spangenberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enxebre
Copy link
Member Author

enxebre commented Oct 30, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 6e6faee into openshift:master Oct 30, 2019
@openshift-ci-robot
Copy link
Contributor

@enxebre: Updated the following 6 configmaps:

  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-kubernetes-autoscaler-release-4.3.yaml using file ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-release-4.3.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-kubernetes-autoscaler-release-4.3.yaml using file ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-release-4.3.yaml
  • ci-operator-4.4-configs configmap in namespace ci using the following files:
    • key openshift-kubernetes-autoscaler-release-4.4.yaml using file ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-release-4.4.yaml
  • ci-operator-4.4-configs configmap in namespace ci-stg using the following files:
    • key openshift-kubernetes-autoscaler-release-4.4.yaml using file ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-release-4.4.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-kubernetes-autoscaler-master.yaml using file ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-kubernetes-autoscaler-master.yaml using file ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-master.yaml

In response to this:

This is likely making unit fails here openshift/kubernetes-autoscaler#120
due to https://golang.org/doc/go1.12#library

# k8s.io/autoscaler/cluster-autoscaler/vendor/k8s.io/component-base/cli/flag
cluster-autoscaler/vendor/k8s.io/component-base/cli/flag/ciphersuites_flag.go:80:18: undefined: tls.VersionTLS13
[ERROR] PID 17: hack/test-go.sh:190: `go test -i ${gotest_flags} ${test_packages}` exited with status 2.
[INFO]          Stack Trace:
[INFO]            1: hack/test-go.sh:190: `go test -i ${gotest_flags} ${test_packages}`
[INFO]   Exiting with code 2.
[ERROR] hack/test-go.sh exited with code 2 after 00h 01m 09s
sh-4.2$

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants