Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MCO] set go 1.21 build_root for release 2.11 and 2.12 #54478

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[MCO] set go 1.21 build_root for release 2.11 and 2.12 #54478

merged 1 commit into from
Jul 22, 2024

Conversation

thibaultmg
Copy link
Contributor

@thibaultmg thibaultmg commented Jul 17, 2024 •
edited
Loading

Merging a PR in the release-2.11 raises an error suggesting that tests are being run on go 1.20.
This PR upgrades the build_root for ACM release 2.11 and 2.12. It is already set in main.

@thibaultmg thibaultmg changed the title set go 1.21 build_root for release 2.11 and 2.12 [MCO] set go 1.21 build_root for release 2.11 and 2.12 Jul 17, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@thibaultmg: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-multicluster-observability-operator-release-2.12-images stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.12-sonarcloud stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.12-test-e2e stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.12-test-unit stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.11-images stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.11-sonarcloud stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.11-test-e2e stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.11-test-unit stolostron/multicluster-observability-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from haoqing0110 and songleo July 17, 2024 15:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
douglascamata
douglascamata approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thibaultmg
Copy link
Contributor Author

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thibaultmg
Copy link
Contributor Author

/pj-rehearse ci/rehearse/stolostron/multicluster-observability-operator/release-2.11/test-unit

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: job(s): ci/rehearse/stolostron/multicluster-observability-operator/release-2.11/test-unit either don't exist or were not found to be affected, and cannot be rehearsed

@thibaultmg
Copy link
Contributor Author

/pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.11-test-unit

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thibaultmg thibaultmg mentioned this pull request Jul 18, 2024
Merged
@thibaultmg
Copy link
Contributor Author

/pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.11-test-unit

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thibaultmg
Copy link
Contributor Author

/pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.11-sonarcloud

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thibaultmg
Copy link
Contributor Author

/pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.12-sonarcloud

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thibaultmg
Copy link
Contributor Author

/pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.11-sonarcloud

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

@thibaultmg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/multicluster-observability-operator/release-2.12/sonarcloud 9154caf link unknown /pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.12-sonarcloud
ci/rehearse/stolostron/multicluster-observability-operator/release-2.11/sonarcloud 9154caf link unknown /pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.11-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thibaultmg
Copy link
Contributor Author

@douglascamata I just checked and the two failing steps have been failing for a very long time in the repo and thus are expected to fail here. Do you know who could force merge this?

@thibaultmg
Copy link
Contributor Author

/pj-rehearsal ack

@thibaultmg
Copy link
Contributor Author

/pj-rehearse ack pull-ci-stolostron-multicluster-observability-operator-release-2.11-sonarcloud

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thibaultmg
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@thibaultmg: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 22, 2024
@openshift-ci-robot
Copy link
Contributor

@thibaultmg: job(s): ack either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-merge-bot openshift-merge-bot bot merged commit 4f414b3 into openshift:master Jul 22, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglascamata douglascamata douglascamata approved these changes

@haoqing0110 haoqing0110 Awaiting requested review from haoqing0110

@songleo songleo Awaiting requested review from songleo

Assignees

@douglascamata douglascamata

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thibaultmg @openshift-ci-robot @douglascamata