Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up deprecated tool: populate-owners #5115

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Clean up deprecated tool: populate-owners #5115

merged 1 commit into from
Sep 20, 2019

Conversation

hongkailiu
Copy link
Member

It is deprecated by https://github.com/openshift/ci-tools/tree/master/cmd/autoowners

/cc @openshift/openshift-team-developer-productivity-test-platform

@openshift-ci-robot openshift-ci-robot requested a review from a team September 20, 2019 00:21
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2019
@hongkailiu
Copy link
Member Author

@stevekuznetsov
Not directly related to this PR, i did not find the script for image bumping ...

And thanks to @petr-muller

$ git show 4b03af61053eead8bbd18ca42f5819a95f008a5c
commit 4b03af61053eead8bbd18ca42f5819a95f008a5c
Author: Petr Muller <[email protected]>
Date:   Thu Sep 12 12:03:36 2019 +0200

    remove bumg-prow-images.sh, we now use autobumper

@hongkailiu
Copy link
Member Author

/test owners

@petr-muller
Copy link
Member

I don't think hack/validate-owners.sh should be removed, that still protects us from directories not having OWNERS when target repos do not have it.

@hongkailiu
Copy link
Member Author

I don't think hack/validate-owners.sh should be removed, that still protects us from directories not having OWNERS when target repos do not have it.

Overkilled. Recovered.

petr-muller
petr-muller approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hongkailiu,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0e0415a into openshift:master Sep 20, 2019
wking added a commit to wking/openshift-release that referenced this pull request Oct 4, 2021
@wking
OWNERS_ALIASES: Remove no-longer-auto-maintained cruft
bae8130 
This prunes aliases that used to be maintained automatically.  The
tooling that used to maintain them was removed in 58d12ef (Clean up
deprecated tool: populate-owners, 2019-09-19, openshift#5115), and the tooling
that replaced it will not pick up that missing functionality [1,2].
This commit removes the stale "auto-generated" comment, and also all
unused aliases:

  $ diff -u <(yaml2json <OWNERS_ALIASES | jq -r '.aliases | keys[]' | sort) <(find . -name OWNERS -exec grep -h "$(yaml2json <OWNERS_ALIASES | jq -r '.aliases | keys | join("\\|")')" {} \+ | sed -n 's/^ *- //p' | sort | uniq) | grep '^-'

[1]: openshift/ci-tools#115 (comment)
[2]: https://issues.redhat.com/browse/DPTP-690
@wking wking mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongkailiu @petr-muller @openshift-ci-robot @openshift-merge-robot