Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openstack beta repos to ironic image #4836

Closed
wants to merge 1 commit into from
Closed

Add openstack beta repos to ironic image #4836

wants to merge 1 commit into from

Conversation

elfosardo
Copy link
Contributor

This PR depends on #4835
Please DO NOT MERGE before that is landed
I guess it will fail CI anyway.... oh well!

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, juliakreger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo elfosardo mentioned this pull request Aug 23, 2019
Merged
This was referenced Aug 23, 2019
Closed
Closed
This was referenced Aug 28, 2019
Closed
Closed
Closed
@hardys
Copy link
Contributor

hardys commented Sep 10, 2019

/retest

@elfosardo
Copy link
Contributor Author

this needs an update as we changed the name of the repos in #4835
going to push a change later today

@elfosardo elfosardo force-pushed the ironic-openstack-beta branch from 7cd8435 to 6640291 Compare September 11, 2019 06:37
@elfosardo
Copy link
Contributor Author

I lied and just push the change today
Apparently we can't use the new repo for 4.2, so I'm adding it to 4.3 conf only for the time being

@elfosardo elfosardo force-pushed the ironic-openstack-beta branch from 6640291 to 28a2642 Compare September 11, 2019 06:41
@elfosardo elfosardo mentioned this pull request Sep 11, 2019
Closed
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

5 similar comments
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@elfosardo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/ironic-image/release-4.2/images 7cd8435b599bc60de5b6b33e200c732a0a33422e link /test pj-rehearse
ci/rehearse/openshift/ironic-image/master/images 7cd8435b599bc60de5b6b33e200c732a0a33422e link /test pj-rehearse
ci/rehearse/openshift/ironic-image/release-4.3/images 28a2642 link /test pj-rehearse
ci/prow/pj-rehearse 28a2642 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo elfosardo mentioned this pull request Sep 19, 2019
Merged
elfosardo added a commit to elfosardo/release that referenced this pull request Oct 1, 2019
@elfosardo
Use ubi 8 as base image for ironic
0cb774a 
This should install correct base python3 packages.
We might need to combine this with openshift#4836 to have the correct
ironic packages installed.
@elfosardo elfosardo closed this Oct 1, 2019
@elfosardo
Copy link
Contributor Author

superseded by #5090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb Awaiting requested review from russellb

@juliakreger juliakreger Awaiting requested review from juliakreger

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elfosardo @openshift-ci-robot @hardys @juliakreger