Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: Skip more jobs #30436

Closed
wants to merge 1 commit into from
Closed

openstack: Skip more jobs #30436

wants to merge 1 commit into from

Conversation

pierreprinetti
Copy link
Member

With this change, the Installer presubmits e2e-openstack-parallel and
e2e-openstack-proxy are run on the same triggers as e2e-openstack.

Notably, documentation and UPI changes do not trigger these IPI jobs any
more.

@pierreprinetti
Copy link
Member Author

/cc mandre EmilienM

@openshift-ci openshift-ci bot requested review from EmilienM and mandre July 13, 2022 13:37
mandre
mandre reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
@pierreprinetti
Copy link
Member Author

/assign patrickdillon

@EmilienM
Copy link
Member

/lgtm

@pierreprinetti
Copy link
Member Author

@sadasu perhaps?

@pierreprinetti pierreprinetti mentioned this pull request Aug 31, 2022
Merged
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@pierreprinetti
openstack: Skip more jobs
077f249 
With this change, the Installer presubmits `e2e-openstack-parallel` and
`e2e-openstack-proxy` are run on the same triggers as `e2e-openstack`.

Notably, documentation and UPI changes do not trigger these IPI jobs any
more.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse 077f249 link false /test pj-rehearse
ci/rehearse/openshift/installer/release-4.12/e2e-openstack-parallel 077f249 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/release-4.12/e2e-openstack-kuryr 077f249 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/release-4.12/e2e-openstack-proxy 077f249 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/release-4.13/e2e-openstack-parallel 077f249 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/release-4.13/e2e-openstack-proxy 077f249 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-openstack-parallel 077f249 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/release-4.13/e2e-openstack-kuryr 077f249 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-openstack-proxy 077f249 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-openstack-kuryr 077f249 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre
mandre reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@pierreprinetti
Copy link
Member Author

/cc @patrickdillon

@sadasu
Copy link
Contributor

sadasu commented Sep 23, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@pierreprinetti
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@zaneb
Copy link
Member

zaneb commented Sep 23, 2022

The commit message is a bit misleading here, because this will result in far fewer jobs being skipped. Previously these jobs only ran on a change to the openstack platform. after this they'll run on any change except changes to other platforms. I'm not sure that is intended.

@pierreprinetti
Copy link
Member Author

The commit message is a bit misleading here, because this will result in far fewer jobs being skipped. Previously these jobs only ran on a change to the openstack platform. after this they'll run on any change except changes to other platforms. I'm not sure that is intended.

Thank you for your comment. We'll review the workload raise this change is expected to provoke, and see if it's acceptable.

@sadasu
Copy link
Contributor

sadasu commented Sep 23, 2022

/approve cancel
Until further investigation into what openstack jobs need to run when non-platform installer changes are made.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM, mandre, pierreprinetti
Once this PR has been reviewed and has the lgtm label, please ask for approval from patrickdillon by writing /assign @patrickdillon in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@pierreprinetti
Copy link
Member Author

Closing, as the outcome of merging this is not unambiguously positive for our CI.

@pierreprinetti pierreprinetti deleted the os_skip branch October 6, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@mandre mandre

@EmilienM EmilienM

@patrickdillon patrickdillon

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierreprinetti @EmilienM @sadasu @zaneb @mandre @patrickdillon