make golint more confident #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
This was referenced Sep 27, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, spangenberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@paulfantom: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Apr 13, 2022
…fig: Bot doesn't need lgtm or approval
We trust it, and it's no longer authorized to add its own labels:
* FAILED channels/fast-4.7: Promote 4.7.48. It was promoted to the
feeder fast by 3ea452a650 (Merge pull request openshift#1745 from
openshift/promote-4.7.48-to-fast, 2022-04-13) 1:39:00.240438
ago. 403 {"message": "Must have admin rights to Repository.",
"documentation_url":
"https://docs.github.com/rest/reference/issues#add-labels-to-an-issue"}
Also drop the backport business for all authors, because we don't have
release branches in this repository.
I'd also like to drop bugzilla/invalid-bug, because we don't tie
changes to bugs. But CI presubmits didn't like that [1]:
{"component":"checkconfig","file":"k8s.io/test-infra/prow/cmd/checkconfig/main.go:90","func":"main.reportWarning","level":"warning","msg":"the following orgs or repos enable the bugzilla plugin but do not forbid the bugzilla/invalid-bug label for merging: [repo: openshift/cincinnati-graph-data]","severity":"warning","time":"2022-04-13T18:08:18Z"}
I poked around a bit trying to find a way to drop the Bugzilla plugin
from the graph-data repo, but couldn't find the incantation, so for
now I'm keeing the invalid-bug label in these queries.
[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/27826/pull-ci-openshift-release-master-config/1514304177340157952#1:build-log.txt%3A10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate #1676.
/assign @enxebre @spangenberg