Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates/installer: copy artifacts after install #1630

Merged
merged 1 commit into from
Sep 22, 2018
Merged

templates/installer: copy artifacts after install #1630

merged 1 commit into from
Sep 22, 2018

Conversation

crawford
Copy link
Contributor

The installer is moving the generation of terraform.tfvars from "init"
to "install".

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2018
@crawford
Copy link
Contributor Author

/cc @stevekuznetsov

The installer is moving the generation of terraform.tfvars from "init"
to "install".
@@ -202,9 +202,10 @@ objects:
cd /tmp/cluster
tectonic init --config=inputs.yaml
mv -f ${NAME}/* /tmp/cluster/
cp config.yaml internal.yaml terraform.tfvars /tmp/artifacts/installer/
cp config.yaml internal.yaml /tmp/artifacts/installer/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get these even if install fails. Maybe put it in an EXIT trap like this to copy this asset out regardless of install success?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we keep this dead simple since it's holding up some PRs that have to go in. Once those merge, I'm going to come back and update all of this to work with the new installer.

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2018
@openshift-merge-robot openshift-merge-robot merged commit df59faf into openshift:master Sep 22, 2018
@openshift-ci-robot
Copy link
Contributor

@crawford: Updated the following 2 configmaps:

  • prow-job-cluster-launch-installer-e2e-smoke configmap using the following files:
    • key cluster-launch-installer-e2e-smoke.yaml using file ci-operator/templates/cluster-launch-installer-e2e-smoke.yaml
  • prow-job-cluster-launch-installer-e2e configmap using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/cluster-launch-installer-e2e.yaml

In response to this:

The installer is moving the generation of terraform.tfvars from "init"
to "install".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford crawford deleted the installer-tfvars branch September 23, 2018 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants