-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates/installer: copy artifacts after install #1630
templates/installer: copy artifacts after install #1630
Conversation
/cc @stevekuznetsov |
The installer is moving the generation of terraform.tfvars from "init" to "install".
@@ -202,9 +202,10 @@ objects: | |||
cd /tmp/cluster | |||
tectonic init --config=inputs.yaml | |||
mv -f ${NAME}/* /tmp/cluster/ | |||
cp config.yaml internal.yaml terraform.tfvars /tmp/artifacts/installer/ | |||
cp config.yaml internal.yaml /tmp/artifacts/installer/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to get these even if install
fails. Maybe put it in an EXIT trap like this to copy this asset out regardless of install
success?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather we keep this dead simple since it's holding up some PRs that have to go in. Once those merge, I'm going to come back and update all of this to work with the new installer.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@crawford: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The installer is moving the generation of terraform.tfvars from "init"
to "install".