osa- skip-tests determinize-prow-jobs jobs invalidates skip regexp #1520
Conversation
openshift-ci-robot
added
approved
|
related to this: openshift/ci-operator#150 |
| @@ -17,9 +17,11 @@ parameters: | |||
| - name: CLUSTER_TYPE | |||
| value: "azure" | |||
| required: true | |||
| - name: TEST_SUITE | |||
There was a problem hiding this comment.
Why are you adding the TEST_SUITE* back? They were intentionally removed in #1261.
There was a problem hiding this comment.
I was not aware of this.
| -e2e-output-dir /tmp/artifacts -report-dir /tmp/artifacts/junit \ | ||
| -test.timeout=2h || rc=$? | ||
| -test.timeout=2h ${PROVIDER_ARGS-} || rc=$? |
There was a problem hiding this comment.
Why PROVIDER_ARGS? If you want to consume it, you should probably set it. For example:
$ git grep PROVIDER_ARGS ci-operator/templates/cluster-launch-installer-e2e.yaml
ci-operator/templates/cluster-launch-installer-e2e.yaml: export PROVIDER_ARGS='-provider
gce -gce-zone=us-east1-c -gce-project=openshift-gce-devel-ci'
ci-operator/templates/cluster-launch-installer-e2e.yaml: export PROVIDER_ARGS="-provider
aws -gce-zone=${region}"
ci-operator/templates/cluster-launch-installer-e2e.yaml: -test.timeout=10m ${PROVIDER_
RGS-} || rc=$?
ci-operator/templates/cluster-launch-installer-e2e.yaml: -test.timeout=20m ${PROVIDER_
RGS-} || rc=$?But if you don't have providers to distinguish between, it seems simpler to just remove PROVIDER_ARGS entirely.
There was a problem hiding this comment.
Azure dont use it, so we remove it so not to confuse
There was a problem hiding this comment.
Azure dont use it, so we remove it so not to confuse
So remove your addition here?
| report failed soon after an annotated objects has failed)|(s2i build with | ||
| a root user image should create a root build and pass with a privileged | ||
| SCC)).* | ||
| value: .*((The HAProxy router should set Forwarded headers appropriately)|(oc new-app should succeed with a --name of 58 characters)|(process valueFrom in build strategy environment variables should successfully resolve valueFrom in docker build environment variables)|(prune builds based on settings in the buildconfig should prune failed builds based on the failedBuildsHistoryLimit setting)|(Prometheus when installed to the cluster should start and expose a secured proxy and unsecured metrics)|(Prometheus when installed to the cluster should start and expose a secured proxy and verify build metrics)|(templateservicebroker)|(deploymentconfigs with multiple image change triggers [Conformance] should run a successful deployment with multiple triggers)|(templateinstance readiness test should report failed soon after an annotated objects has failed)|(s2i build with a root user image should create a root build and pass with a privileged SCC)).* |
There was a problem hiding this comment.
I struggled with getting either sane wrapping or no wrapping through CI, and ended up giving up. You unwrapped line here is hitting that same issue.
mjudeikis
force-pushed
the
osa-logic-update
branch
from
c7134f1 to
945ca2e
Compare
openshift-ci-robot
added
size/XS
mjudeikis
force-pushed
the
osa-logic-update
branch
2 times, most recently
from
5e1bfdc to
26c2894
Compare
mjudeikis
force-pushed
the
osa-logic-update
branch
from
26c2894 to
8297976
Compare
|
@Kargakis ready to give it a second try |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis, thanasisk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mjudeikis: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
when running it invaldiates regexp and tests are not skipped
docker run -it -v $(pwd)/jobs:/jobs:z registry.svc.ci.openshift.org/ci/determinize-prow-jobs:latest --prow-jobs-dir /jobs