Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncollapse mistakenly collapsed inline bash #1325

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

petr-muller
Copy link
Member

It seems that the trailing whitespace in the original file made the Marshaler to output the bash fragment collapsed like this.

When I removed the trailing whitespace in the original, pre-determinize state and applied the determinizer, I got the uncollapsed results.

/cc @stevekuznetsov @wking

It seems that the trailing whitespace in the original file made the
Marshaler to output the bash fragment collapsed like this.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2018
@wking
Copy link
Member

wking commented Aug 30, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2018
@stevekuznetsov
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2018
@openshift-merge-robot openshift-merge-robot merged commit d90db8a into openshift:master Aug 30, 2018
@openshift-ci-robot
Copy link
Contributor

@petr-muller: Updated the job-config configmap using the following files:

  • key openshift-jenkins-presubmits.yaml using file ci-operator/jobs/openshift/jenkins/openshift-jenkins-presubmits.yaml

In response to this:

It seems that the trailing whitespace in the original file made the Marshaler to output the bash fragment collapsed like this.

When I removed the trailing whitespace in the original, pre-determinize state and applied the determinizer, I got the uncollapsed results.

/cc @stevekuznetsov @wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants