Merge pull request #1313 from petr-muller/comments

Ignore comments in config-ordering checks

ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml

@@ -39,6 +39,8 @@ presubmits:
     decorate: true
     name: pull-ci-origin-installer-e2e-aws
     rerun_command: /test e2e-aws
+    # The abomination below is equivalent to `^((?!Documentation).)*$`. Since
+    # Go doesn't support negative lookaheads, we are stuck with the following.
     run_if_changed: ^([^D]|D(D|oD|ocD|ocuD|ocum(D|e(D|n(D|t(D|aD|atD|atiD|atioD)))))*([^Do]|o[^Dc]|oc[^Du]|ocu[^Dm]|ocum([^De]|e([^Dn]|n([^Dt]|t([^Da]|a[^Dt]|at[^Di]|ati[^Do]|atio[^Dn]))))))*(D(D|oD|ocD|ocuD|ocum(D|e(D|n(D|t(D|aD|atD|atiD|atioD)))))*(o|oc|ocu|ocum(e(n(t(a|at|ati|atio)?)?)?)?)?)?$
     skip_cloning: true
     spec:

hack/validate-prow-job-ordering.sh

@@ -17,7 +17,7 @@ cp -r "${jobs_dir}" "${workdir}"
 
 "$( dirname "${BASH_SOURCE[0]}" )/order-prow-job-config.sh"
 
-if ! diff -Naupr "${workdir}/jobs" "${jobs_dir}"> "${workdir}/diff"; then
+if ! diff -Naupr -I '^[[:space:]]*#.*' "${workdir}/jobs" "${jobs_dir}"> "${workdir}/diff"; then
   cat << EOF
 [ERROR] This check enforces Prow Job configuration YAML file format (ordering,
 [ERROR] linebreaks, indentation) to be consistent over the whole repository. We have