Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKD-220: Update c9s.repo to install cri-o 1.29.5 #1541

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

aleskandro
Copy link
Member

Updating the repo to install the latest crio 1.29 for 4.16. the 4.17 repo is not available yet. This should be backported to release-4.16

/cc @travier

@openshift-ci openshift-ci bot requested a review from travier July 2, 2024 12:51
@aleskandro
Copy link
Member Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@aleskandro: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aleskandro aleskandro changed the title Update c9s.repo to install cri-o 1.29.5 OKD-220: Update c9s.repo to install cri-o 1.29.5 Jul 2, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2024

@aleskandro: This pull request references OKD-220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Updating the repo to install the latest crio 1.29 for 4.16. the 4.17 repo is not available yet. This should be backported to release-4.16

/cc @travier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@travier
Copy link
Member

travier commented Jul 2, 2024

We should not backport OKD-SCOS changes to branched releases. Everything should be built from the master branch.

@travier
Copy link
Member

travier commented Jul 2, 2024

Change LGTM but no backport.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2467e5e and 2 for PR HEAD 71f0c6b in total

@travier
Copy link
Member

travier commented Jul 3, 2024

/retest

@aleskandro
Copy link
Member Author

aleskandro commented Jul 4, 2024

One failure is about #1540

@aleskandro
Copy link
Member Author

        harness.go:1823: mach.Start() failed: machine "fdb74dc7-2401-42d2-832a-99d4eff463f5" failed basic checks: detected failed or stuck systemd units: some systemd units failed: systemd-network-generator.service; <nil>
=== RUN   rpmostree.upgrade-rollback/rollback
--- PASS: rpmostree.upgrade-rollback (135.24s)
    --- PASS: rpmostree.upgrade-rollback/upgrade (53.24s)
    --- PASS: rpmostree.upgrade-rollback/rollback (41.65s)
--- PASS: ext.config.shared.networking.nmstate.state (76.11s)
--- PASS: rhcos.network.init-interfaces-test (176.85s)
--- PASS: coreos.ignition.failure (30.27s)
--- FAIL: ext.config.shared.networking.prefer-ignition-networking (41.61s)
        harness.go:1823: mach.Start() failed: machine "ccc3eb72-4873-4f85-b223-4de8e8ca3528" failed basic checks: detected failed or stuck systemd units: some systemd units failed: systemd-network-generator.service; <nil> 
 --- PASS: ext.config.shared.ignition.resource.remote (74.59s)
--- FAIL: ext.config.shared.networking.bridge-static-via-kargs (42.05s)
        harness.go:1823: mach.Start() failed: machine "0e06ddb3-9af2-46fe-b3d5-bf94d496b894" failed basic checks: detected failed or stuck systemd units: some systemd units failed: systemd-network-generator.service; <nil>
--- PASS: ext.config.shared

@aleskandro
Copy link
Member Author

/test scos-9-build-test-qemu

@jlebon
Copy link
Member

jlebon commented Jul 4, 2024

Yeah, SCOS CI is broken right now as you see. I don't think we need to block on this.

/override ci/prow/scos-9-build-test-qemu

But as @travier said, this shouldn't be backported. It doesn't seem like there's a way to cancel a /cherrypick command, so we'll just have to close the PR it opens.

Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/scos-9-build-test-qemu

In response to this:

Yeah, SCOS CI is broken right now as you see. I don't think we need to block on this.

/override ci/prow/scos-9-build-test-qemu

But as @travier said, this shouldn't be backported. It doesn't seem like there's a way to cancel a /cherrypick command, so we'll just have to close the PR it opens.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

@aleskandro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 211d46f into openshift:master Jul 4, 2024
7 checks passed
@openshift-cherrypick-robot

@aleskandro: new pull request created: #1543

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants