Simplifications for CONTRIBUTING.adoc for Vagrant users #9817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bparees, PTAL |
| @@ -145,48 +145,46 @@ TIP: To ensure you get the latest image first run `vagrant box remove fedora_ins | |||
|
|
|||
| $ vagrant ssh | |||
|
|
|||
| 7. Run a build: | |||
| 7. You are now ready to edit the source, rebuild and restart OpenShift to test your changes. | |||
There was a problem hiding this comment.
this isn't really a step. Can you just make it part of the end of "step 6" or maybe "step 5"?
|
lgtm, please squash your commits and i'll put a merge tag on it. |
- Remove instructions to set $PATH using Vagrant image - this is done in the base image - Simplify Vagrant commands for first-time developers - Clarify that any username and password will do for console when using Vagrant
jim-minter
force-pushed
the
CONTRIBUTING-fixes
branch
from
b212c5d to
e866e79
Compare
|
Squashed. |
|
thanks @jim-minter |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to e866e79 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6218/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6249/) (Image: devenv-rhel7_4584) |
|
flake #9840 |
|
Evaluated for origin merge up to e866e79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the learning curve and keystrokes for new contributors using Vagrant.