Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy: move cli-related packages in cmd #9692

Merged
merged 1 commit into from
Jul 20, 2016
Merged

deploy: move cli-related packages in cmd #9692

merged 1 commit into from
Jul 20, 2016

Conversation

0xmichalis
Copy link
Contributor

@smarterclayton PTAL

@deads2k @bparees let's consolidate all cli-related interfaces under subpackage/cmd. Mentioning you since pkg/authorization, pkg/user, and pkg/build already have a reaper package.

@0xmichalis
Copy link
Contributor Author

[test]

@smarterclayton
Copy link
Contributor

Please save all major refactors for post rebase.

On Mon, Jul 4, 2016 at 5:27 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test SUCCESS (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5765/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9692 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABG_p0KkgOYGD0qf9tdO5mhV6ZDb1KLgks5qSXq5gaJpZM4JEiQ5
.

@0xmichalis
Copy link
Contributor Author

Flaked on #9766

[test]

@0xmichalis
Copy link
Contributor Author

same flake as before

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 9be6c5a

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6094/)

@mfojtik
Copy link
Contributor

mfojtik commented Jul 20, 2016

LGTM [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 20, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6542/) (Image: devenv-rhel7_4630)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 9be6c5a

@openshift-bot openshift-bot merged commit 4ecbe85 into openshift:master Jul 20, 2016
@0xmichalis 0xmichalis deleted the cleanup-deployment-packages branch July 20, 2016 10:59
deads2k pushed a commit to deads2k/origin that referenced this pull request Jul 20, 2016
@deads2k
Merge pull request openshift#9692 from kargakis/cleanup-deployment-pa…
55bf66e 
…ckages

Merged by openshift-bot
bparees pushed a commit to bparees/origin that referenced this pull request Jul 20, 2016
@bparees
Merge pull request openshift#9692 from kargakis/cleanup-deployment-pa…
c68826f 
…ckages

Merged by openshift-bot
@bparees bparees mentioned this pull request Aug 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xmichalis @smarterclayton @openshift-bot @mfojtik