-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not hard code build name in extended tests #9605
Conversation
A previous version used to use 'out', lost in a refactor.
@bparees, I caught this while reading the build extended tests. PTAL. |
if we're going to do it this way, i think we should log the buildname we got back from start-build. there have been issues where start-build returns some other value (not a build name) and the tests fail and it can be confusing to understand what happened. |
Check the line above the one I changed :) |
lol. lgtm :) |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 0889626 |
continuous-integration/openshift-jenkins/test ABORTED (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5499/) |
Hoping today Jenkins will be more determined to merge :) |
not looking good so far :( |
[merge] |
2 similar comments
[merge] |
[merge] |
quota bug and fuzzer bug. |
[merge] |
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5702/) (Image: devenv-rhel7_4503) |
[merge] |
Evaluated for origin merge up to 0889626 |
10 merge tags. probably not even a record. |
A previous version used to use 'out', lost in a refactor in #8591.