[WIP] Add separate call for updating DC status #6479
Conversation
|
|
| @@ -222,7 +222,7 @@ func (o DeployOptions) deploy(config *deployapi.DeploymentConfig, out io.Writer) | |||
| } | |||
|
|
|||
| config.Status.LatestVersion++ | |||
| _, err = o.osClient.DeploymentConfigs(config.Namespace).Update(config) | |||
| _, err = o.osClient.DeploymentConfigs(config.Namespace).UpdateStatus(config) | |||
There was a problem hiding this comment.
is this backwards compatible?
There was a problem hiding this comment.
actually, we would never want a client to modify status to trigger a deployment... a client would modify spec, the controller would modify status to indicate the requested deployment was done
There was a problem hiding this comment.
There is #6337 for fixing that.
There was a problem hiding this comment.
I don't want a version of the CLI to exist which makes a call to the status subresource in order to trigger a deployment
There was a problem hiding this comment.
I see. Then we need #6337 to be fixed first.
There was a problem hiding this comment.
FWIW in the short term, updates to the status won't result in a new deployment unless status.latestVersion changes.
|
Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
openshift-bot
added
needs-rebase
This commit adds a separete call for updating the status part of a DeploymentConfig.
openshift-bot
removed
the
needs-rebase
|
Superseded by #7149 |
Blocked on #6337
@ironcladlou @deads2k
Needs a couple of unit tests.
Fixes #6465