Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-36182: Removes dependency on samples operator images #28904

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[release-4.16] OCPBUGS-36182: Removes dependency on samples operator images #28904

merged 1 commit into from
Jul 9, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #28840

/assign adambkaplan

/cherrypick release-4.15 release-4.14

@apoorvajagtap
Import ruby imageStream from Red Hat registries
8b2e7b2 
OpenShift-Samples operator still points to stale image versions.
These non-existing image references lead to test-failures. This commit
eliminates the dependency on samples operator for importing the ruby IS,
and instead creates a custom ruby imageStream.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 25, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33486 has been cloned as Jira Issue OCPBUGS-36182. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-36182: Removes dependency on samples operator images

In response to this:

This is an automated cherry-pick of #28840

/assign adambkaplan

/cherrypick release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-33486: Removes dependency on samples operator images [release-4.16] OCPBUGS-36182: Removes dependency on samples operator images Jun 25, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 25, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36182, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #28840

/assign adambkaplan

/cherrypick release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from coreydaley and divyansh42 June 25, 2024 17:37
@apoorvajagtap
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 25, 2024
@openshift-ci-robot
Copy link

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-36182, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-33486 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-33486 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apoorvajagtap
Copy link
Contributor

/retest-required

@apoorvajagtap
Copy link
Contributor

/retest

@sayan-biswas
Copy link

Does the change have any impact on the failing tests?

adambkaplan
adambkaplan approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Other failing tests are unrelated.

@adambkaplan
Copy link
Contributor

/label backport-risk-assessed

Test code change only, verified in 4.17

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 26, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@adambkaplan
Copy link
Contributor

/assign @dgoodwin

For approval, as this is touching origin test framework code.

This was referenced Jun 26, 2024
Closed
Open
@adambkaplan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 27, 2024
@ardaguclu ardaguclu mentioned this pull request Jul 1, 2024
Merged
@apoorvajagtap
Copy link
Contributor

/retest-required

@stbenjam
Copy link
Member

stbenjam commented Jul 8, 2024

/approve

1 similar comment
@xueqzhan
Copy link
Contributor

xueqzhan commented Jul 8, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot, stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a68dff7 and 2 for PR HEAD 8b2e7b2 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-ipsec-serial 8b2e7b2 link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 8b2e7b2 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 8b2e7b2 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 8b2e7b2 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@apoorvajagtap
Copy link
Contributor

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit ab3e340 into openshift:release-4.16 Jul 9, 2024
24 of 28 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36182: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36182 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #28840

/assign adambkaplan

/cherrypick release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 9, 2024
Merged
@openshift-cherrypick-robot
Copy link
Author

@openshift-cherrypick-robot: new pull request created: #28927

In response to this:

This is an automated cherry-pick of #28840

/assign adambkaplan

/cherrypick release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202407090839.p0.gab3e340.assembly.stream.el9 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

@divyansh42 divyansh42 Awaiting requested review from divyansh42

Assignees

@dgoodwin dgoodwin

@stbenjam stbenjam

@adambkaplan adambkaplan

@sayan-biswas sayan-biswas

@kasturinarra kasturinarra

@jadhaj jadhaj

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.