Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2033720: sync imagestreams #26750

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

yselkowitz
Copy link
Contributor

  • Sync examples
  • image_ecosystem: use unique tags in test logs
  • image_ecosystem: sync s2i image tags

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jan 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@yselkowitz: This pull request references Bugzilla bug 2033720, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

Bug 2033720: sync imagestreams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 14, 2022
@yselkowitz
Copy link
Contributor Author

Waiting on openshift/cluster-samples-operator#408

Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just one question on psql volume mount path

@@ -383,7 +383,7 @@
},
"volumeMounts": [
{
"mountPath": "/var/lib/postgresql/data",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the image expecting this path change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a change, but a bugfix; see nodeshift-starters/nodejs-rest-http-crud#228. Note that this brings it in line with other pg-based templates.

@yselkowitz
Copy link
Contributor Author

/test all

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/test all

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz yselkowitz force-pushed the imagestreams branch 2 times, most recently from 86f7513 to 4afbb59 Compare January 19, 2022 04:14
@yselkowitz
Copy link
Contributor Author

/test all

Many imagestreams support both RHEL/UBI 7 and 8 based images of the same
language runtime, so version is not necessarily unique but tag is.
This adds new ImageStreamTags in 4.10 (from RHEL/UBI 8.5 and RHSCL 3.8),
and restores some default tags which are being supported for the full
ten years on RHEL/UBI 8.
@yselkowitz yselkowitz marked this pull request as ready for review January 20, 2022 04:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2022
@yselkowitz
Copy link
Contributor Author

/retest
/assign @adambkaplan
/cc @gabemontero @dperaza4dustbit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@yselkowitz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@yselkowitz
Copy link
Contributor Author

/assign @bparees

@bparees
Copy link
Contributor

bparees commented Jan 20, 2022

@dperaza4dustbit let's get you (or the appropriate person associated w/ the samples operator) added to:

https://github.com/openshift/origin/blob/master/OWNERS_ALIASES

that file is used here to ensure that team leads can approve PRs to test/extended/util/annotate/generated:

https://github.com/openshift/origin/blob/master/test/extended/util/annotate/generated/OWNERS

@bparees
Copy link
Contributor

bparees commented Jan 20, 2022

(and also the other owners files this PR touches)

@bparees
Copy link
Contributor

bparees commented Jan 20, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit 79b83ad into openshift:master Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@yselkowitz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2033720 has not been moved to the MODIFIED state.

In response to this:

Bug 2033720: sync imagestreams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants