-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2033720: sync imagestreams #26750
Bug 2033720: sync imagestreams #26750
Conversation
yselkowitz
commented
Jan 14, 2022
- Sync examples
- image_ecosystem: use unique tags in test logs
- image_ecosystem: sync s2i image tags
Skipping CI for Draft Pull Request. |
@yselkowitz: This pull request references Bugzilla bug 2033720, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Waiting on openshift/cluster-samples-operator#408 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just one question on psql volume mount path
@@ -383,7 +383,7 @@ | |||
}, | |||
"volumeMounts": [ | |||
{ | |||
"mountPath": "/var/lib/postgresql/data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the image expecting this path change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a change, but a bugfix; see nodeshift-starters/nodejs-rest-http-crud#228. Note that this brings it in line with other pg-based templates.
/test all |
/retest |
/test all |
/retest |
86f7513
to
4afbb59
Compare
/test all |
Many imagestreams support both RHEL/UBI 7 and 8 based images of the same language runtime, so version is not necessarily unique but tag is.
This adds new ImageStreamTags in 4.10 (from RHEL/UBI 8.5 and RHSCL 3.8), and restores some default tags which are being supported for the full ten years on RHEL/UBI 8.
4afbb59
to
e56fb69
Compare
/retest |
@yselkowitz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/assign @bparees |
@dperaza4dustbit let's get you (or the appropriate person associated w/ the samples operator) added to: https://github.com/openshift/origin/blob/master/OWNERS_ALIASES that file is used here to ensure that team leads can approve PRs to test/extended/util/annotate/generated: |
(and also the other owners files this PR touches) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yselkowitz: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2033720 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |