Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1718052: must-gather: make sure audit logs do not contain OAuth tokens #23074

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Bug 1718052: must-gather: make sure audit logs do not contain OAuth tokens #23074

merged 1 commit into from
Jun 13, 2019

Conversation

enj
Copy link
Contributor

@enj enj commented Jun 6, 2019

Signed-off-by: Monis Khan [email protected]

@deads2k

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@enj
Copy link
Contributor Author

enj commented Jun 6, 2019

/hold

Need both to merge before this is safe:

openshift/cluster-kube-apiserver-operator#499
openshift/cluster-openshift-apiserver-operator#205

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2019
@enj enj force-pushed the enj/i/no_audit_oauth_tokens branch from 6d9d02f to ba9f7a7 Compare June 7, 2019 15:10
@enj
Copy link
Contributor Author

enj commented Jun 7, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2019
@enj
Copy link
Contributor Author

enj commented Jun 7, 2019

/cherrypick release-4.1

@openshift-cherrypick-robot
Copy link

@enj: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj enj changed the title must-gather: make sure audit logs do not contain OAuth tokens Bug 1718052: must-gather: make sure audit logs do not contain OAuth tokens Jun 7, 2019
@openshift-ci-robot
Copy link

@enj: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1718052: must-gather: make sure audit logs do not contain OAuth tokens

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 7, 2019
@deads2k
Copy link
Contributor

deads2k commented Jun 7, 2019

/approve
/assign @sanchezl

@enj
Copy link
Contributor Author

enj commented Jun 7, 2019 

=== RUN   TestHighProirotyFlushUnschedulableQLeftover
==================
WARNING: DATA RACE
Read at 0x00c000108e48 by goroutine 90:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).flushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:497 +0x24a
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).flushUnschedulableQLeftover-fm()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:490 +0x41
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152 +0x61
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153 +0x108
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.Until()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x5a

Previous write at 0x00c000108e48 by goroutine 88:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.TestHighProirotyFlushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue_test.go:980 +0x7d9
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163

Goroutine 90 (running) created at:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).run()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:315 +0x18a
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.NewPriorityQueueWithClock()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:307 +0x98b
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.NewPriorityQueue()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:290 +0x68
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.TestHighProirotyFlushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue_test.go:933 +0x4f
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163

Goroutine 88 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:916 +0x65a
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1157 +0xa8
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1155 +0x523
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1072 +0x2eb
  main.main()
      _testmain.go:126 +0x334
==================
==================
WARNING: DATA RACE
Read at 0x00c000108e28 by goroutine 90:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).flushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:497 +0x24a
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).flushUnschedulableQLeftover-fm()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:490 +0x41
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152 +0x61
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153 +0x108
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.Until()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x5a

Previous write at 0x00c000108e28 by goroutine 88:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.TestHighProirotyFlushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue_test.go:979 +0x60e
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163

Goroutine 90 (running) created at:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).run()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:315 +0x18a
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.NewPriorityQueueWithClock()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:307 +0x98b
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.NewPriorityQueue()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:290 +0x68
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.TestHighProirotyFlushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue_test.go:933 +0x4f
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163

Goroutine 88 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:916 +0x65a
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1157 +0xa8
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1155 +0x523
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1072 +0x2eb
  main.main()
      _testmain.go:126 +0x334
==================
==================
WARNING: DATA RACE
Write at 0x00c0003f24b0 by goroutine 90:
  runtime.mapdelete_faststr()
      /usr/local/go/src/runtime/map_faststr.go:297 +0x0
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*UnschedulablePodsMap).delete()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:802 +0xc4
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).movePodsToActiveQueue()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:674 +0xaf
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).flushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:504 +0x42e
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).flushUnschedulableQLeftover-fm()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:490 +0x41
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152 +0x61
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153 +0x108
  github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait.Until()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x5a

Previous read at 0x00c0003f24b0 by goroutine 88:
  runtime.mapaccess1_faststr()
      /usr/local/go/src/runtime/map_faststr.go:12 +0x0
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.TestHighProirotyFlushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue_test.go:979 +0x58b
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163

Goroutine 90 (running) created at:
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.(*PriorityQueue).run()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:315 +0x18a
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.NewPriorityQueueWithClock()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:307 +0x98b
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.NewPriorityQueue()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go:290 +0x68
  github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue.TestHighProirotyFlushUnschedulableQLeftover()
      /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/scheduler/internal/queue/scheduling_queue_test.go:933 +0x4f
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163

Goroutine 88 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:916 +0x65a
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1157 +0xa8
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:865 +0x163
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1155 +0x523
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1072 +0x2eb
  main.main()
      _testmain.go:126 +0x334
==================
--- FAIL: TestHighProirotyFlushUnschedulableQLeftover (0.00s)
    testing.go:809: race detected during execution of test

@enj
Copy link
Contributor Author

enj commented Jun 7, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Jun 9, 2019

/hold

This is looking at the wrong files :|

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2019
@enj
Copy link
Contributor Author

enj commented Jun 11, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Jun 13, 2019

/cherrypick release-4.1

@openshift-cherrypick-robot
Copy link

@enj: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@sanchezl
Copy link
Contributor

/pony twilight sparkle

@openshift-ci-robot
Copy link

@sanchezl: pony image

In response to this:

/pony twilight sparkle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj enj force-pushed the enj/i/no_audit_oauth_tokens branch from 56eeb6d to 85a10de Compare June 13, 2019 17:48
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@enj
Copy link
Contributor Author

enj commented Jun 13, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2019
@sanchezl
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enj, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7bfc3b6 into openshift:master Jun 13, 2019
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 13, 2019
Merged
@openshift-cherrypick-robot
Copy link

@enj: new pull request created: #23167

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@sanchezl sanchezl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enj @openshift-cherrypick-robot @openshift-ci-robot @deads2k @sanchezl @openshift-merge-robot