Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force kube 1.14 golang.org/x/net #22519

Closed
wants to merge 5 commits into from
Closed

Conversation

enj
Copy link
Contributor

@enj enj commented Apr 9, 2019

This allows the http2 code to respect "Connection" == "close" to mean sending a GOAWAY and tearing down the TCP connection.

Signed-off-by: Monis Khan [email protected]

@openshift/sig-auth @openshift/sig-master

@smarterclayton I believe you said you wanted this to be bumped to latest?

@openshift-ci-robot openshift-ci-robot added sig/master size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 9, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: pweil-

If they are not already assigned, you can assign the PR to them by writing /assign @pweil- in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor

Bumped to kube, preferably.

@enj enj force-pushed the enj/i/bump_http2 branch from 8dbda34 to 4517d21 Compare April 9, 2019 18:39
@enj
Copy link
Contributor Author

enj commented Apr 9, 2019

Bumped to kube, preferably.

Set it to release-branch.go1.12 to match kube 1.14

@enj enj changed the title Force latest golang.org/x/net Force kube 1.14 golang.org/x/net Apr 9, 2019
@@ -176,6 +176,9 @@ import:
# auth (for sally)
- package: github.com/gorilla/sessions
version: a3acf13e802c358d65f249324d14ed24aac11370
# auth (for sally)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thing we all love sally

@deads2k
Copy link
Contributor

deads2k commented Apr 10, 2019

So uh, for those of us in the peanut gallery, is there a thing you need to do to trigger this? You definitely need to at least try to make test proving you destroy these connections and if you have code to add to make this bump effective, you need that too. I'm not seeing a good reason to do this bump yet.

enj added 5 commits April 10, 2019 14:47
This allows the http2 code to respect "Connection" == "close" to
mean sending a GOAWAY and tearing down the TCP connection.

Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
The OAuth server is now resilient against misdirected requests as we
aggressively close connections that could lead to misdirected
requests (HTTP2 + TLS).

Signed-off-by: Monis Khan <[email protected]>
@openshift-ci-robot
Copy link

@enj: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/unit 95efa7d link /test unit
ci/prow/e2e-aws-serial 95efa7d link /test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka
Copy link
Contributor

There were some issues upstream in net package, not sure if we hook up the one from golang or the experimental to those particular places. (e.g. golang/go#27044)

This would also mean we take pretty significant change from upstream that is compiled and tested with different go version. And there are regressions if we consider bumping to go1.12 - kubernetes/kubernetes#75833 kubernetes/kubernetes#75837

@enj
Copy link
Contributor Author

enj commented Apr 11, 2019

#22529

@enj enj closed this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/master size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants