-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force kube 1.14 golang.org/x/net #22519
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: enj If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumped to kube, preferably. |
Set it to |
@@ -176,6 +176,9 @@ import: | |||
# auth (for sally) | |||
- package: github.com/gorilla/sessions | |||
version: a3acf13e802c358d65f249324d14ed24aac11370 | |||
# auth (for sally) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good thing we all love sally
So uh, for those of us in the peanut gallery, is there a thing you need to do to trigger this? You definitely need to at least try to make test proving you destroy these connections and if you have code to add to make this bump effective, you need that too. I'm not seeing a good reason to do this bump yet. |
This allows the http2 code to respect "Connection" == "close" to mean sending a GOAWAY and tearing down the TCP connection. Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
The OAuth server is now resilient against misdirected requests as we aggressively close connections that could lead to misdirected requests (HTTP2 + TLS). Signed-off-by: Monis Khan <[email protected]>
@enj: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There were some issues upstream in This would also mean we take pretty significant change from upstream that is compiled and tested with different go version. And there are regressions if we consider bumping to go1.12 - kubernetes/kubernetes#75833 kubernetes/kubernetes#75837 |
This allows the http2 code to respect "Connection" == "close" to mean sending a GOAWAY and tearing down the TCP connection.
Signed-off-by: Monis Khan [email protected]
@openshift/sig-auth @openshift/sig-master
@smarterclayton I believe you said you wanted this to be bumped to latest?