-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodeenv plugin and DS controller to not process openshift.io/node-selector if scheduler.alpha.kubernetes.io/node-selector is set on pods namespace #21058
Conversation
…notation key scheduler.alpha.kubernetes.io/node-selector in nodeenv admission plugin.
openshift-io/node-selector if scheduler.alpha.kubernetes.io/node-selector is set.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aveshagarwal, derekwaynecarr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test gcp |
3 similar comments
/test gcp |
/test gcp |
/test gcp |
I'm seeing
in the |
Well we are past the |
keeping fingers crossed. |
@sjenning @derekwaynecarr
manual pick of #21033