Add oc image extract to support release tooling
#20466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
smarterclayton
force-pushed
the
extract
branch
4 times, most recently
from
b2937f3
to
4074b4b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest
…On Tue, Jul 31, 2018 at 2:41 PM OpenShift CI Robot ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton>: The following test
*failed*, say /retest to rerun them all:
Test name Commit Details Rerun command
ci/prow/gcp 5a021fe
<5a021fe>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20466/pull-ci-origin-e2e-gcp/1816/> /test
gcp
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20466 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p3f6AJHrWFKbwOGmEwsoAN1Oo6pMks5uMKSQgaJpZM4Vmff5>
.
|
|
@smarterclayton how much of this overlaps with skopeo and containers/image stuff ? |
|
skopeo doesn't support the use cases we have here - because it downloads
into an overlay or image specific filesystem. This is more focused on
things like:
* I want to get a directory out of an image onto disk
* I want to get a specific file out of an image onto disk
* I want to leverage the above two as part of a CI flow
We're going to be using this as part of building the update payload
(because we want operators to own their config as well).
Containers image is too inconsistent with our existing stack - I do think
in the future the delta between docker/distribution, docker/archive,
containers/image, the new google/go-containerregistry, and such will
converge and that we can gradually unify the underlying tooling. But
they're not the same use cases right now.
…On Wed, Aug 1, 2018 at 5:34 AM Michal Fojtik ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton> how much of this
overlaps with skopeo and containers/image stuff ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20466 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p2_aEFu8u5dxLoe9RVh57LFRGXDFks5uMXYTgaJpZM4Vmff5>
.
|
|
/retest |
1 similar comment
|
/retest |
smarterclayton
changed the title
oc image extract to support release toolingoc image extract to support release tooling
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
This is needed for prototyping releasing, going to add it as experimental for 3.11 |
bparees
reviewed
Aug 13, 2018
pkg/oc/cli/image/extract/extract.go
Outdated
|
|
||
| flag.BoolVar(&o.OnlyFiles, "only-files", o.OnlyFiles, "Only extract regular files and directories from the image.") | ||
|
|
||
| flag.BoolVar(&o.Force, "force", o.Force, "If set, the command will attempt to upload all layers instead of skipping those that are already uploaded.") |
There was a problem hiding this comment.
pretty sure the help text on this is wrong? this command doesn't upload anything
bparees
reviewed
Aug 13, 2018
pkg/oc/cli/image/extract/extract.go
Outdated
| flag.BoolVar(&o.OnlyFiles, "only-files", o.OnlyFiles, "Only extract regular files and directories from the image.") | ||
|
|
||
| flag.BoolVar(&o.Force, "force", o.Force, "If set, the command will attempt to upload all layers instead of skipping those that are already uploaded.") | ||
| flag.IntVar(&o.MaxPerRegistry, "max-per-registry", o.MaxPerRegistry, "Number of concurrent requests allowed per registry.") |
There was a problem hiding this comment.
when would there be more than one registry involved? (carry-over from image mirror?)
There was a problem hiding this comment.
You can extract two images from different registries
There was a problem hiding this comment.
is it necessary that we support that? I think allowing multiple images to extract from, in a single commandline, is going to frustrate our ability to support args in a sane way. Why not just support a single image to extract from, per invocation?
Among other things, this would make it easier to support multiple paths to extract (e.g. "--extract /tmp --extract /etc").
|
/retest |
|
/retest |
…s to disk Uses a subset of docker/pkg/archive that is slightly more flexible than the upstream.
smarterclayton
force-pushed
the
extract
branch
from
5a021fe
to
76fbf4e
Compare
|
updated |
|
the flag syntax looks better to me. |
|
Tagging, will iterate more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command will be used as part of the foundation for building out our upgrade payload images (grab manifests from individual images and combine them).