Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream machinery picks #20242

Merged
merged 4 commits into from
Jul 12, 2018
Merged

upstream machinery picks #20242

merged 4 commits into from
Jul 12, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 6, 2018

  1. track schemes by name so we know which scheme is failing
  2. only ignore events for GC and quota

both are lgtm'd upstream

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2018
@openshift-bot
Copy link
Contributor

/test cross

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jul 11, 2018

/retest

@liggitt
Copy link
Contributor

liggitt commented Jul 11, 2018

do we need both of these ahead of 1.11.1?

@deads2k
Copy link
Contributor Author

deads2k commented Jul 11, 2018

do we need both of these ahead of 1.11.1?

I could pull the second one if you wanted. I really need that scheme naming to move the separate scheme stuff ahead. Now that both work, why not?

@deads2k
Copy link
Contributor Author

deads2k commented Jul 11, 2018

/retest

@liggitt
Copy link
Contributor

liggitt commented Jul 11, 2018

ok

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Jul 11, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ea877ac into openshift:master Jul 12, 2018
@deads2k deads2k mentioned this pull request Jul 23, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @openshift-bot @liggitt @openshift-ci-robot @openshift-merge-robot