Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 60301: Fix Deployment with Recreate strategy not to wait on pods in terminal phase #18760

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Feb 27, 2018

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1547169

/cc @tnozicka picked for you
/cc @derekwaynecarr FYI
/cc @smarterclayton we need this before we cut 3.9

@mfojtik mfojtik added this to the 3.9.0 milestone Feb 27, 2018
@openshift-ci-robot
Copy link

@mfojtik: GitHub didn't allow me to request PR reviews from the following users: FYI, picked, for, you.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1547169

/cc @tnozicka picked for you
/cc @derekwaynecarr FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2018
@mfojtik mfojtik added queue/critical-fix sig/master kind/delivery-blocker and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 27, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2018
@tnozicka
Copy link
Contributor

/test extended_networking_minimal

@tnozicka
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2018
@tnozicka
Copy link
Contributor

/retest

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 27, 2018

@tnozicka e2e is permabroken: #18762

if other tests will run fine, I will green button merge this

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 27, 2018

All tests are green, the e2e is permanently broken on #18762 and this is delivery blocker, green button merging this.

@mfojtik mfojtik merged commit f48a8cf into openshift:master Feb 27, 2018
@openshift-ci-robot
Copy link

@mfojtik: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end d6fc815 link /test end_to_end

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik mfojtik deleted the pick-60301 branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/delivery-blocker lgtm Indicates that a PR is ready to be merged. queue/critical-fix sig/master size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants