Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 58415: Improve messaging on resize #18509

Merged
merged 1 commit into from
Feb 9, 2018
Merged

UPSTREAM: 58415: Improve messaging on resize #18509

merged 1 commit into from
Feb 9, 2018

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Feb 7, 2018

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 7, 2018
@openshift-merge-robot openshift-merge-robot added needs-api-review vendor-update Touching vendor dir or related files labels Feb 7, 2018
@childsb
Copy link
Contributor

childsb commented Feb 7, 2018

/approve

@gnufied
Copy link
Member Author

gnufied commented Feb 8, 2018

/assign @liggitt

@liggitt
Copy link
Contributor

liggitt commented Feb 8, 2018

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2018
@childsb
Copy link
Contributor

childsb commented Feb 8, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, gnufied, liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18423, 18255, 18526, 18539, 18509).

@openshift-merge-robot openshift-merge-robot merged commit 35cbe8e into openshift:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childsb childsb Awaiting requested review from childsb

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@childsb childsb

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gnufied @childsb @liggitt @openshift-ci-robot @openshift-merge-robot