Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 59279: nodelifecycle: set OutOfDisk unknown on node timeout #18417

Merged
merged 1 commit into from
Feb 9, 2018
Merged

UPSTREAM: 59279: nodelifecycle: set OutOfDisk unknown on node timeout #18417

merged 1 commit into from
Feb 9, 2018

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Feb 2, 2018 •
edited
Loading

@sjenning sjenning added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 2, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 2, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2018
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2018
@sjenning sjenning removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2018
@sjenning
Copy link
Contributor Author

sjenning commented Feb 5, 2018

flake #17883 #17556
/retest

@aveshagarwal
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2018
@aveshagarwal
Copy link
Contributor

@derekwaynecarr could you approve this?

@ingvagabund
Copy link
Member

/lgtm

@derekwaynecarr
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, derekwaynecarr, ingvagabund, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2018
@ingvagabund
Copy link
Member

/test end_to_end

@ingvagabund
Copy link
Member

/test extended_conformance_install

@aveshagarwal
Copy link
Contributor

flake: #18136

@aveshagarwal
Copy link
Contributor

/test extended_conformance_install

@sjenning
Copy link
Contributor Author

sjenning commented Feb 9, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit ae63a98 into openshift:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@aveshagarwal aveshagarwal

@derekwaynecarr derekwaynecarr

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sjenning @aveshagarwal @ingvagabund @derekwaynecarr @openshift-ci-robot @openshift-merge-robot