Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 57349: add watch to requirements for quota-able resources #17863

Merged
merged 1 commit into from
Dec 22, 2017
Merged

UPSTREAM: 57349: add watch to requirements for quota-able resources #17863

merged 1 commit into from
Dec 22, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 18, 2017

Fixes part two of #17784

This avoids putting istags in the list at all

/assign soltysh
/assign derekwaynecarr

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 18, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 19, 2017

/retest

soltysh
soltysh approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please for the upstream to merge or be tagged for merge first

@deads2k
Copy link
Contributor Author

deads2k commented Dec 20, 2017

lgtm'd upstream

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 20, 2017

/retest

1 similar comment
@soltysh
Copy link
Contributor

soltysh commented Dec 21, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 21, 2017

#17811

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 21, 2017

#17556

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 21, 2017

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Dec 21, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 22, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit c50bc3f into openshift:master Dec 22, 2017
@deads2k deads2k deleted the quota-02-watch branch January 24, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@soltysh soltysh

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @openshift-ci-robot @soltysh @openshift-merge-robot @derekwaynecarr