Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 49885: Ignore UDP metrics in kubelet #17106

Merged
merged 1 commit into from
Nov 14, 2017
Merged

UPSTREAM: 49885: Ignore UDP metrics in kubelet #17106

merged 1 commit into from
Nov 14, 2017

Conversation

runcom
Copy link
Member

@runcom runcom commented Oct 31, 2017

openshift-node seems to have high CPU usage during tests. This patch should fix that.

Upstream PR: kubernetes/kubernetes#49885
Upstream issue: kubernetes/kubernetes#54448

@sjug PTAL

Signed-off-by: Antonio Murdaca [email protected]

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 31, 2017
@stevekuznetsov
Copy link
Contributor

/unasign
/assign @sjug

@runcom
Copy link
Member Author

runcom commented Nov 13, 2017

/test unit

@mrunalp
Copy link
Member

mrunalp commented Nov 13, 2017

@derekwaynecarr PTAL

@derekwaynecarr
Copy link
Member

/kind bug
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Nov 13, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, runcom

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2017
@derekwaynecarr
Copy link
Member

fyi @sjenning

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@derekwaynecarr
Copy link
Member

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 681dbb8 into openshift:master Nov 14, 2017
@runcom runcom deleted the cherry-pick-kube-49885 branch November 14, 2017 09:43
@openshift-ci-robot
Copy link

@runcom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 2e3dc58 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_install 2e3dc58 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Contributor

liggitt commented Nov 14, 2017

this should not have merged into 3.8 prior to the rebase

This was referenced Nov 14, 2017
Closed
Merged
openshift-merge-robot added a commit that referenced this pull request Nov 21, 2017
@openshift-merge-robot
Merge pull request #17303 from sjenning/pick-49885-3.7
c4939e3 
Automatic merge from submit-queue.

UPSTREAM: 49885: Ignore UDP metrics in kubelet [3.7]

master PR #17106

@derekwaynecarr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soltysh soltysh

@derekwaynecarr derekwaynecarr

@stevekuznetsov stevekuznetsov

@sjug sjug

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@runcom @stevekuznetsov @mrunalp @derekwaynecarr @openshift-merge-robot @openshift-bot @openshift-ci-robot @liggitt @soltysh @sjug