don't mangle config.GinkgoConfig.FocusString #16842
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jim-minter Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
size/M
|
@smarterclayton ptal |
|
or @bparees ptal |
| case !include: | ||
| // do nothing | ||
| case isSerial: | ||
| if !isExcluded && isConformance { |
There was a problem hiding this comment.
Please don't refactor this chunk of code, it's orthogonal to your change.
| if strings.Contains(node.CodeLocation().FileName, "/origin/test/") && !strings.Contains(node.Text(), "[Suite:openshift") { | ||
| node.SetText(node.Text() + " [Suite:openshift]") | ||
| } | ||
| if strings.Contains(node.CodeLocation().FileName, "/kubernetes/test/e2e/") { | ||
| node.SetText(node.Text() + " [Suite:k8s]") | ||
| } | ||
|
|
||
| switch syntheticSuite { |
There was a problem hiding this comment.
Please do not do this.
|
If it's not implementable via regexes I don't want to do it via hacking the pending status of flags either. I'm considering removing the serial suite altogether from the job so that this is not an issue. Do builds have any serial components? |
|
The only one in builds is test/extended/builds/run_policy.go |
|
@jim-minter: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The logic attempting to modify config.GinkgoConfig.FocusString looks wrong to me. It looks like it's attempting to use alternation, however after appending "|" it overwrites the string. In any case, I think boolean AND is wanted, not alternation, and this is not implementable using Go regexes.