Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 51633: update GC controller to wait until controllers have … #16617

Merged
merged 1 commit into from
Oct 6, 2017
Merged

UPSTREAM: 51633: update GC controller to wait until controllers have … #16617

merged 1 commit into from
Oct 6, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 29, 2017

…been initialized

fixes #16573

@ironcladlou it did not pick cleanly.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 29, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2017
@soltysh soltysh added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2017
@soltysh
Copy link
Contributor

soltysh commented Oct 4, 2017

I've added do-not-merge until the rebase lands.

@ironcladlou
Copy link
Contributor

LGTM, I feel pretty confident in the GC tests, so if they pass I think this is good.

@soltysh soltysh removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2017
soltysh
soltysh approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2017
@soltysh
Copy link
Contributor

soltysh commented Oct 5, 2017

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 5, 2017
@ironcladlou ironcladlou mentioned this pull request Oct 5, 2017
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Contributor

mfojtik commented Oct 6, 2017

/retest

2 similar comments
@0xmichalis
Copy link
Contributor

/retest

@soltysh
Copy link
Contributor

soltysh commented Oct 6, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2017 •
edited
Loading

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/origin/verify 7aa1f2a link /test origin-verify
ci/openshift-jenkins/origin/unit 7aa1f2a link /test origin-ut
ci/openshift-jenkins/cmd 7aa1f2a link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16617, 16719).

@openshift-merge-robot openshift-merge-robot merged commit fec4e8a into openshift:master Oct 6, 2017
@deads2k deads2k deleted the controller-14-gcwait branch January 24, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

@ironcladlou ironcladlou

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic during master startup
8 participants
@deads2k @soltysh @ironcladlou @openshift-merge-robot @openshift-bot @mfojtik @0xmichalis @openshift-ci-robot