Remove usless test and resolved comments #16000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/M
|
/unassign |
|
/retest |
enj
suggested changes
Aug 29, 2017
| // the policy cache taking time to react | ||
| // try to add Valerie to a non-existent role, looping until it is done. | ||
| // If a Not Found error is raised, simply retry as this is likely due to | ||
| // the role cache taking time to react |
There was a problem hiding this comment.
I think in general this wait no longer makes any sense (there is no role cache).
if err := addValerie.AddRole(); err != nil {
t.Fatalf("unexpected error: %v", err)
}@deads2k any thoughts?
| @@ -318,7 +319,7 @@ func TestAuthorizationResolution(t *testing.T) { | |||
| roleWithGroup.Name = "with-group" | |||
| roleWithGroup.Rules = append(roleWithGroup.Rules, authorizationapi.PolicyRule{ | |||
| Verbs: sets.NewString("list"), | |||
| Resources: sets.NewString("builds"), // TODO we may need to track these down | |||
| Resources: sets.NewString("builds"), | |||
Signed-off-by: Simo Sorce <[email protected]>
|
/retest |
|
Still seeing this flake even if it has been closed #14575 |
|
/lgtm |
enj
approved these changes
Sep 6, 2017
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, simo5 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 15885, 15973, 16000) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15815