Image policy is resolving images on replica sets by default #15867
Conversation
openshift-merge-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
approved
smarterclayton
force-pushed
the
fix_imagepolicy
branch
5 times, most recently
from
6e8b9d7
to
c2613d2
Compare
|
/retest |
|
@smarterclayton pls update this PR with changes from #15868 so we can ship it |
|
It is |
|
/retest |
| // value is DoNotAttempt. This overrides the global image policy for a matching resource. If there | ||
| // are multiple rules matching a resource, any rule that requests resolution or rewrite will | ||
| // result in rewrite. | ||
| Type ImageResolutionType |
There was a problem hiding this comment.
@smarterclayton isn't this duplicate to Policy? seems like rebase going wrong
smarterclayton
force-pushed
the
fix_imagepolicy
branch
from
c2613d2
to
66fe69b
Compare
Even when local names are not requested, the image policy plugin is deciding to rewrite image references in replica sets that point to the integrated registry (with tags) to use digests. This causes the deployment controller that created them to get wedged (because it detects a change to the template) and become unable to update status on that replica set. https://bugzilla.redhat.com/show_bug.cgi?id=1481801
smarterclayton
force-pushed
the
fix_imagepolicy
branch
from
66fe69b
to
4f99fe7
Compare
|
Updated |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Even when local names are not requested, the image policy plugin is
deciding to rewrite image references in replica sets that point to the
integrated registry (with tags) to use digests. This causes the
deployment controller that created them to get wedged (because it
detects a change to the template) and become unable to update status on
that replica set.
https://bugzilla.redhat.com/show_bug.cgi?id=1481801