Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up cluster up loglevel 1 #15584

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Aug 1, 2017

No description provided.

@openshift-merge-robot openshift-merge-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2017
@csrwng
Copy link
Contributor

csrwng commented Aug 1, 2017

@bparees if we're leaving log level 1 only for reporting progress, we should fix these other ones:

$ find ./pkg/oc/bootstrap -name "*.go" | xargs grep -F "V(1)."
./pkg/oc/bootstrap/docker/dockerhelper/helper.go:		glog.V(1).Infof("Error getting container %q log: %v", container, err)
./pkg/oc/bootstrap/docker/down.go:		glog.V(1).Infof("error: cannot kill socat: %v", err)
./pkg/oc/bootstrap/docker/down.go:		glog.V(1).Infof("Error stopping origin container: %v", err)
./pkg/oc/bootstrap/docker/down.go:			glog.V(1).Infof("Error stopping container %s: %v", name, err)
./pkg/oc/bootstrap/docker/down.go:			glog.V(1).Infof("Error removing container %s: %v", name, err)
./pkg/oc/bootstrap/docker/errors/errors.go:	glog.V(1).Infof("Unexpected error: %v", err)
./pkg/oc/bootstrap/docker/openshift/ansible.go:	glog.V(1).Infof("Wrote inventory to local file: %s", file.Name())
./pkg/oc/bootstrap/docker/openshift/ansible.go:	glog.V(1).Infof("Uploading file %s to host destination: %s", file.Name(), dest)
./pkg/oc/bootstrap/docker/openshift/ansible.go:		glog.V(1).Infof("Generated ansible inventory:\n %s\n", inventory.String())
./pkg/oc/bootstrap/docker/openshift/ansible.go:		glog.V(1).Infof("Running image %s with playbook: %s", image, playbook)
./pkg/oc/bootstrap/docker/openshift/ansible.go:		glog.V(1).Infof("With binding: %s", configBind)
./pkg/oc/bootstrap/docker/openshift/ansible.go:		glog.V(1).Infof("With binding: %s", inventoryBind)
./pkg/oc/bootstrap/docker/openshift/helper.go:		glog.V(1).Infof("Found more than one node, will attempt to remove duplicate nodes")
./pkg/oc/bootstrap/docker/openshift/helper.go:			glog.V(1).Infof("Deleting extra node %s", nodesToRemove[i])
./pkg/oc/bootstrap/docker/openshift/helper.go:	glog.V(1).Infof("Copying OpenShift config to local directory %s", tempDir)
./pkg/oc/bootstrap/docker/openshift/helper.go:	glog.V(1).Infof("Reading node config from %s", configPath)
./pkg/oc/bootstrap/docker/openshift/helper.go:		glog.V(1).Infof("Could not read node config: %v", err)
./pkg/oc/bootstrap/docker/openshift/helper.go:	glog.V(1).Infof("Reading master config from %s", configPath)
./pkg/oc/bootstrap/docker/openshift/helper.go:		glog.V(1).Infof("Could not read master config: %v", err)
./pkg/oc/bootstrap/docker/openshift/helper_unix.go:		glog.V(1).Infof("error: cannot kill socat: %v", err)
./pkg/oc/bootstrap/docker/openshift/helper_unix.go:	glog.V(1).Infof("Started socat with pid: %d", cmd.Process.Pid)
./pkg/oc/bootstrap/docker/run/run.go:				glog.V(1).Infof("Error deleting container %q: %v", id, err)
./pkg/oc/bootstrap/docker/up.go:		glog.V(1).Infof("Failed to check Docker API version: %v", err)

@bparees
Copy link
Contributor Author

bparees commented Aug 1, 2017

@csrwng I didn't remove all the ones you referenced, I think some of them are still useful progress indicators, but, updated.

@bparees
Copy link
Contributor Author

bparees commented Aug 1, 2017

flake #14385
/retest

@csrwng
Copy link
Contributor

csrwng commented Aug 1, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, csrwng

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Contributor

/test end_to_end

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15533, 15414, 15584, 15529, 15309)

@openshift-merge-robot openshift-merge-robot merged commit 5ee8547 into openshift:master Aug 2, 2017
@bparees bparees deleted the clusterup_logging branch August 23, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants