Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add short TTL cache to token authentication #14916

Merged
merged 5 commits into from
Sep 8, 2017
Merged

Add short TTL cache to token authentication #14916

merged 5 commits into from
Sep 8, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 27, 2017 •
edited
Loading

Addresses frequent etcd lookups due to high-volume controllers

Fixes authenticator aspect of https://bugzilla.redhat.com/show_bug.cgi?id=1464579

@liggitt liggitt changed the title Add short TTL cache to token authentication WIP - Add short TTL cache to token authentication Jun 27, 2017
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2017
@deads2k deads2k self-assigned this Jun 28, 2017
@deads2k deads2k added this to the 3.6.0 milestone Jun 28, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Jun 29, 2017

[test]

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2017
@smarterclayton
Copy link
Contributor

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 61eb559

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3063/) (Base Commit: 3c5875f) (PR Branch Commit: 61eb559)

@openshift-merge-robot openshift-merge-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 24, 2017
@liggitt liggitt changed the title WIP - Add short TTL cache to token authentication Add short TTL cache to token authentication Aug 7, 2017
@openshift-merge-robot openshift-merge-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2017
@liggitt liggitt modified the milestones: 3.6.x, 3.6.0 Aug 7, 2017
@liggitt liggitt mentioned this pull request Aug 7, 2017
Merged
@liggitt liggitt modified the milestones: 3.7.0, 3.6.x Aug 7, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 12, 2017

/retest

1 similar comment
@liggitt
Copy link
Contributor Author

liggitt commented Aug 18, 2017

/retest

@enj
Copy link
Contributor

enj commented Aug 24, 2017

@openshift/sig-security

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2017
@smarterclayton
Copy link
Contributor

Generally LGTM - a 10s window on either side is not a large deal for a huge reduction in peak load during request storms.

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 30, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 31, 2017

upstream commits are merged, any last comments from @openshift/sig-security?

do we still want this for 3.6.1? #15662 is ready and green as well

@deads2k
Copy link
Contributor

deads2k commented Sep 8, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 8a47952 into openshift:master Sep 8, 2017
openshift-merge-robot added a commit that referenced this pull request Sep 9, 2017
@openshift-merge-robot
Merge pull request #15662 from liggitt/token-cache-3.6.1
4aaca6a 
Automatic merge from submit-queue

3.6.x: Add short TTL cache to token authentication

pick of #14916
@liggitt liggitt deleted the token-cache branch September 12, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enj enj

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
7 participants
@liggitt @smarterclayton @openshift-bot @enj @deads2k @openshift-merge-robot @openshift-ci-robot