UPSTREAM: 46608: fixes kubectl cached discovery on Windows #14399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
fabianofranz
added
component/cli
kind/bug
|
Evaluated for origin test up to 21d9860 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1831/) (Base Commit: 5a19120) |
|
[merge][severity: bug] |
|
flake #13984 re[merge][severity: bug] |
|
Evaluated for origin merge up to 21d9860 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/841/) (Base Commit: b2dfb64) (Extended Tests: bug) (Image: devenv-rhel7_6283) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1452073
Upstream PR: kubernetes/kubernetes#46608
The
kubectlcached discovery makes use offunc (f *File) Chmod(mode FileMode) errorwhich is not supported and errors out on Windows, makingoc getand potentially a number of other commands to fail miserably on that platform.os.Chmodby file name, on the other hand, does not error out and should be used instead.@ncdc up to you, but this breaks
ocon Windows pretty badly. Was reported on 3.6.0.