add best practice try/catch, timeout, specifically with extended test…

[gabemontero]

…s in mind

the diff came out a little wonky - try viewing with ignore white space option

but in general existing contents were put inside

try {
   timeout(...) {
   } 
} catch ... {
}

@openshift/devex

[gabemontero]

[testextended][extended:core(openshift pipeline build)]

[gabemontero]

fyi ... adding ?w=1 to the file diff url is the ignore whitespace trigger ... the file diff renders as I described when employed

[bparees]

2 hours? i'm worried about making our test runs take a really long time to fail. is there something in the extended test itself that's going to cap this? regardless i'd hope we could bring it down to 15-20 minutes tops.

[gabemontero]

yeah 2 hours was NOT based on any examination of deployment times or some such ... just a "make it really big so it is not a factor" rationale

I'll switch to 20 minutes.

[gabemontero]

ah ... still waiting on the new client plugin version with the exists since we still can't update the centos image ... will address in separate PR

the tests based on this PR's changes passed, but will clean up above, plus reduce timeout

[gabemontero]

ok updates pushed

[bparees]

lgtm if it passes tests

[gabemontero]

and they just passed :-)

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to a919167

[bparees]

looks like the passing run was your previous commit. this run failed with

+ oc start-build openshift-jee-sample-docker --from-file=target/ROOT.war --follow -n extended-test-jenkins-pipeline-37mv8-n85lx
Uploading file "target/ROOT.war" as binary input for the build ...
Unable to connect to the server: net/http: TLS handshake timeout
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // timeout
[Pipeline] echo
in catch block
[Pipeline] echo
Caught: hudson.AbortException: script returned exit code 1

does this imply the 20 minute timeout might not be long enough?

[gabemontero]

the extended failure this time was the very familiar flake #13984

Further confirmation that the --follow results in the TLS handshake timeout, while in debug PR #14013, where that has been replaced with --wait, we get the more generic exit status -1

And I really am beginning to wonder if there is any correlation with #14148 and some of the console's issues with follow since the rebase.

[openshift-bot]

Evaluated for origin testextended up to a919167

[gabemontero]

On Thu, May 25, 2017 at 1:26 PM, Ben Parees ***@***.***> wrote: looks like the passing run was your previous commit. this run failed with + oc start-build openshift-jee-sample-docker --from-file=target/ROOT.war --follow -n extended-test-jenkins-pipeline-37mv8-n85lx Uploading file "target/ROOT.war" as binary input for the build ... Unable to connect to the server: net/http: TLS handshake timeout [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // node [Pipeline] } [Pipeline] // timeout [Pipeline] echo in catch block [Pipeline] echo Caught: hudson.AbortException: script returned exit code 1 does this imply the 20 minute timeout might not be long enough?

Short answer: no See #14354 (comment) Also, in looking at the various timestamps, 20 minutes had not expired.

…

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14354 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADbadIz7323y4-pVAy4S9ps5tlrOTg7Xks5r9bmwgaJpZM4NmcNK> .

[bparees]

[merge][severity:bug]

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1772/) (Base Commit: 4b3473a)

[openshift-bot]

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/501/) (Base Commit: 4b3473a) (Extended Tests: core(openshift pipeline build))

[bparees]

flake #13980
flake #10773
flake #14385
[merge][severity:bug]

[openshift-bot]

Evaluated for origin merge up to a919167

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/817/) (Base Commit: 21c14af) (Extended Tests: bug) (Image: devenv-rhel7_6280)