Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junitreport integration test compatability with older versions of diff-utils (for Mac OSX) #14310

Conversation

jbornemann
Copy link
Contributor

@jbornemann jbornemann commented May 23, 2017

simple change to fix "make test" for darwin.

Mac OSX has an ancient version of diff-utils, that does not have the tabsize flag.

@stevekuznetsov
Copy link
Contributor

[test]

@stevekuznetsov
Copy link
Contributor

fixes #14311

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 7dd95de

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1684/) (Base Commit: 67275e1)

@stevekuznetsov
Copy link
Contributor

[merge] @jbornemann thanks for taking the time to fix this!

@jbornemann
Copy link
Contributor Author

No problem! Look forward to helping more!

@jbornemann
Copy link
Contributor Author

Uh oh. Does this need [merge][severity: bug] @stevekuznetsov ?

@stevekuznetsov
Copy link
Contributor

Yeah, that timing is unfortunate

[merge][severity: bug]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 7dd95de

@openshift-bot
Copy link
Contributor

openshift-bot commented May 25, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/793/) (Base Commit: 828590c) (Extended Tests: bug) (Image: devenv-rhel7_6271)

@openshift-bot openshift-bot merged commit 4b3473a into openshift:master May 25, 2017
@jbornemann jbornemann deleted the junitreport-integration-compatibility branch May 25, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants