Show restart count warnings only for latest deployment #10440
Conversation
|
[test] |
| @@ -937,6 +937,8 @@ func describeDeployments(f formatter, dcNode *deploygraph.DeploymentConfigNode, | |||
| out := []string{} | |||
| deploymentsToPrint := append([]*kubegraph.ReplicationControllerNode{}, inactiveDeployments...) | |||
|
|
|||
| latestName := deployutil.LatestDeploymentNameForConfig(dcNode.DeploymentConfig) | |||
There was a problem hiding this comment.
Move this just before the loop you are using it
mfojtik
force-pushed
the
fix-restart-warnings
branch
from
49169ed to
ccb73b9
Compare
|
@Kargakis fixed PTAL |
mfojtik
force-pushed
the
fix-restart-warnings
branch
from
ccb73b9 to
bd029bd
Compare
|
@Kargakis PTAL I used different approach, passing the func will allow to get the count for every deployment. I tested this with paused deployment and it works (I can see the pods restarting in "old" deployment). |
|
[test] |
|
Evaluated for origin test up to bd029bd |
Can't you just execute the function and pass the count? |
|
@Kargakis no because I need the graph |
|
LGTM [merge] |
|
Evaluated for origin merge up to bd029bd |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8025/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8025/) (Image: devenv-rhel7_4855) |
Fixes: #10417
@Kargakis PTAL