Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerbuild pull on Docker 1.9 is broken #10017

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

smarterclayton
Copy link
Contributor

We were incorrectly using tags in Repository. Tested in 1.10 and 1.9 and
this code appears to be correct. Also added more error logging.

Fixes #9269

We were incorrectly using tags in Repository. Tested in 1.10 and 1.9 and
this code appears to be correct. Also added more error logging.
@smarterclayton
Copy link
Contributor Author

@csrwng review please, note that from has the tag but that is not valid in docker 1.9.

@smarterclayton
Copy link
Contributor Author

[test]

@csrwng
Copy link
Contributor

csrwng commented Jul 25, 2016

LGTM

@smarterclayton
Copy link
Contributor Author

[merge]

@smarterclayton
Copy link
Contributor Author

xref: openshift/imagebuilder#3

@smarterclayton
Copy link
Contributor Author

[test] #9490

On Mon, Jul 25, 2016 at 2:01 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6833/)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10017 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p3NrqVYl4b3XJHGMkIVCw9G3UUtAks5qZPnlgaJpZM4JUUAX
.

@smarterclayton
Copy link
Contributor Author

[test] #9959

On Mon, Jul 25, 2016 at 4:00 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6848/)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10017 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p38YPeOaHwqrBQb8A_Uo5IKh2JZPks5qZRX1gaJpZM4JUUAX
.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Jul 26, 2016 via email

@smarterclayton
Copy link
Contributor Author

[test] #9959

On Mon, Jul 25, 2016 at 9:30 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6869/)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10017 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p4UHsEakqQEcsQyKKSX80jlKEZJPks5qZWM-gaJpZM4JUUAX
.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 26, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6959/) (Image: devenv-rhel7_4682)

@smarterclayton
Copy link
Contributor Author

[test] secret mount failure

@smarterclayton
Copy link
Contributor Author

[test] database secret mount failure

@smarterclayton
Copy link
Contributor Author

[test] #9959

On Tue, Jul 26, 2016 at 11:15 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6956/)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10017 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p1QfN3plt-OX0bTdVkMMj9SxW8xqks5qZs1MgaJpZM4JUUAX
.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 613ccfd

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6959/)

@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 613ccfd

@openshift-bot openshift-bot merged commit 586d098 into openshift:master Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants