Do not propagate build labels to build pods

[liggitt]

Follow-up from #2295

Adding a single label for selecting a build is ok (though the label should probably be more namespaced than "build"), but we should not be copying all labels from build API objects to their pods. Pods labels are used group pods under services and replication controllers, and copying random labels into builds pods is likely to get them routed to by services (which would be bad) or "managed" by replication controllers (which would also be bad).

[liggitt]

cc @bparees @smarterclayton @soltysh

[liggitt]

Copy code is in build/controller/strategy/util.go#getPodLabels

[bparees]

@liggitt thanks. copying my final comment from the original issue over to here now:

@soltysh I think this needs to:

1. add a new label (openshift.io/build.name)
2. only add that label to build pods and no other labels
3. update the filter logic in our various controllers to use the new label || the old label
4. note that the old label is deprecated ( @smarterclayton how exactly do we do that? )

[smarterclayton]

On Jun 29, 2015, at 11:11 PM, Ben Parees [email protected] wrote:

@liggitt https://github.com/liggitt thanks. copying my final comment from
the original issue over to here now:

@soltysh https://github.com/soltysh I think this needs to:

1. add a new label (openshift.io/build.name)
2. only add that label to build pods and no other labels
3. update the filter logic in our various controllers to use the new label
   || the old label
4. note that the old label is deprecated ( @smarterclayton
   https://github.com/smarterclayton how exactly do we do that? )

This issue should be tagged with the compat tag. We should create a doc in
the root that describes what, when, and how we plan to change. The when is
post 3.1 / 1.2.

—
Reply to this email directly or view it on GitHub
#3502 (comment).

[smarterclayton]

We need to remove support for this before I cut 1.0.7

[bparees]

Remove support for the old label?

[smarterclayton]

Yeah

On Mon, Oct 19, 2015 at 11:32 PM, Ben Parees [email protected]
wrote:

Remove support for the old label?

—
Reply to this email directly or view it on GitHub
#3502 (comment).

[bparees]

The when is post 3.1 / 1.2.

so don't you want to cut 1.0.7 before we remove this?

[smarterclayton]

We announced in 1.0.6 we'd remove it in 1.0.7

On Tue, Oct 20, 2015 at 9:07 AM, Ben Parees [email protected]
wrote:

The when is post 3.1 / 1.2.

so don't you want to cut 1.0.7 before we remove this?

—
Reply to this email directly or view it on GitHub
#3502 (comment).

[bparees]

removing here: #5250