-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to handle envFrom prefix #2362
Comments
@jwforres @cdcabrera FYI |
I was thinking of having the Prefix input always visible. If it's blank, no prefix is set. Something like
|
@spadgett I like that suggestion. Wondering if we can at least add the field level help icon to the right of the "Prefix" label so users can hover to find out what a prefix is for. Do you have a blurb to define that input already? |
Yeah, I think a tooltip makes sense.
Maybe "Optional prefix added to each environment variable name for this resource." ? |
@cdcabrera The new prefix stuff looks good to me! As an aside, the Environment From text looks oddly small to me. @jennyhaines I know we were trying to use that style consistently in font size 10, but it looks off in this context. Thoughts? (Note, this is a separate "Environment From" section, but the "Container node-ex" label still applies to both the top and bottom sections) |
@beanh66 @cdcabrera @spadgett - I see what you're saying about the oddly small "Environment From" text, Colleen. To ensure the right hierarchy between the larger "Container node-ex" grouping, and the "Environment From" subgrouping, I have some suggested changes, labeled in the attached photo. Thoughts? (Also, I wonder if there is better wording for "Environment From" group?) |
cc @sg00dwin |
Automatic merge from submit-queue. Allow EnvFrom Prefix Opened envFrom to allow prefix input. - [x] Minor display logic updates - [x] Design/UX modifications Related to #2182 and closes #2362 ![screen shot 2017-10-25 at 5 06 37 pm](https://user-images.githubusercontent.com/3761375/32026101-d15b6e5c-b9b0-11e7-8405-509d2931056e.png)
Automatic merge from submit-queue. Follow-on updates from jennyhaines Requested changes #2362 (comment) and #2182 (comment) <img width="755" alt="screen shot 2017-10-30 at 3 49 34 pm" src="https://user-images.githubusercontent.com/1874151/32193045-65a72b30-bd8c-11e7-9704-c763ab161392.png"> <img width="326" alt="screen shot 2017-10-30 at 4 08 01 pm" src="https://user-images.githubusercontent.com/1874151/32193095-8c67a470-bd8c-11e7-832b-6dc4914311ce.png">
Our environment from implementation does not handle the
prefix
. We need to make sure we're not dropping values with different prefixes minimally, but we should also let users see and change the prefix values.https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/core/v1/types.go#L1698-L1700
The text was updated successfully, but these errors were encountered: