Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-1281: Add linting and Dockerfile generation from midstream Dockerfile.in #2109

Merged
merged 1 commit into from
May 3, 2021

Conversation

jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Apr 19, 2021

Description

This PR introduces a way to generate CI dockerfile from midstream dockerfile

/hold

cc @vimalk78

https://issues.redhat.com/browse/LOG-1281

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 19, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021
@jcantrill jcantrill changed the title WIP - Generate Dockerfile from midstream LOG-1279: Add linting and Dockerfile generation from midstream Dockerfile.in Apr 20, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2021

@jcantrill: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill changed the title LOG-1279: Add linting and Dockerfile generation from midstream Dockerfile.in LOG-1281: Add linting and Dockerfile generation from midstream Dockerfile.in Apr 26, 2021
@jcantrill jcantrill force-pushed the gen_mid_stream branch 4 times, most recently from 4812637 to 499868a Compare April 28, 2021 13:56
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2021
@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2021
Comment on lines 59 to 60
PROMETHEUS_EXPORTER_VER=6.8.1.0 \
OPENDISTRO_VER=0.10.0.4-redhat-00001 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcantrill
Copy link
Contributor Author

/retest

@vimalk78
Copy link
Contributor

vimalk78 commented May 3, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 53b271b into openshift:master May 3, 2021
@jcantrill jcantrill deleted the gen_mid_stream branch May 3, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants