Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps to 4.10 OpenShift release #40

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

fahlmant
Copy link
Contributor

Bump dependencies to use 4.10 OpenShift release versions

@openshift-ci openshift-ci bot requested review from dofinn and rafael-azevedo March 22, 2022 19:21
@cblecker
Copy link
Member

LGTM

@fahlmant
Copy link
Contributor Author

/hold

../../../../../pkg/mod/sigs.k8s.io/[email protected]/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)

need to fix this

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022
@2uasimojo
Copy link
Member

I believe this means you need to build under go 1.17.

@fahlmant
Copy link
Contributor Author

fahlmant commented Mar 22, 2022

@2uasimojo unfortunately, that gives me

 go-1.17 run example/example.go
../../../../pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)
../../../../pkg/mod/github.com/prometheus/[email protected]/prometheus/internal/go_runtime_metrics.go:22:2: package runtime/metrics is not in GOROOT (/usr/local/go/src/runtime/metrics)

I believe this means client-go requires 1.16

https://github.com/kubernetes/client-go/blob/master/go.mod#L5

@fahlmant
Copy link
Contributor Author

Nvm, I just needed to update the Go SDK on my localhost.

@fahlmant fahlmant merged commit 7b528cc into openshift:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants