Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17] Check manila Storage class before checking manila endpoint #214

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #213

/assign openshift-cherrypick-robot

/cherrypick release-4.16

If manila storage class doesn't exist - skip the test.
If it exists - check that the manila endpoint exists if not - fail
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itzikb-redhat
Copy link
Contributor

/retest

3 similar comments
@MiguelCarpio
Copy link

/retest

@MiguelCarpio
Copy link

/retest

@MiguelCarpio
Copy link

/retest

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MiguelCarpio
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@mandre
Copy link
Member

mandre commented Jan 8, 2025

Could you point to a failed job so that we can verify it fixes an issue in CI?

@MiguelCarpio
Copy link

@mandre

Could you point to a failed job so that we can verify it fixes an issue in CI?

This update fixed the issue [sig-installer][Suite:openshift/openstack] The OpenStack platform on volume creation should create a manila share when using manila storage class: No suitable endpoint could be found in the service catalog in https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-singlestackv6/1865880205910872064.

#213 was already merged and solved the problem, we don't have a specific failed job with this issue at the 4.17 release, however, the enhancement should be applied for all releases (we need to check the endpoint before running the test)

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants