Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17] [OCPBUGS-45069] Add a check for manila share type #207

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #206

/assign openshift-cherrypick-robot

/cherrypick release-4.16

If the share type extra spec of driver_handles_share_servers is true we skip the test.
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MiguelCarpio
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@eurijon
Copy link
Contributor

eurijon commented Dec 5, 2024

/lgtm

@eurijon
Copy link
Contributor

eurijon commented Dec 5, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eurijon, MiguelCarpio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d31d527 into openshift:release-4.17 Dec 5, 2024
5 checks passed
@openshift-cherrypick-robot
Copy link
Author

@openshift-cherrypick-robot: new pull request created: #208

In response to this:

This is an automated cherry-pick of #206

/assign openshift-cherrypick-robot

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants