Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enterprise-4.17] OCPBUGS#43395: Clarify ose-kube-rbac-proxy-rhel9 pull spec details #83888

Open
wants to merge 1 commit into
base: enterprise-4.17
Choose a base branch
from

Conversation

adellape
Copy link
Contributor

@adellape adellape commented Oct 21, 2024

https://issues.redhat.com/browse/OCPBUGS-43395

4.17

Follow-up to #83587 for clarity.

  • Splits the single step into substeps (felt there was too much info jammed into one step previously)
  • More specific about the image name change / switch to RHEL 9
  • User might not have a literal memcached-operator.clusterserviceversion.yaml file unless they ran the tutorials, so clarify that they should look at whatever their project's file is called

Preview: https://83888--ocpdocs-pr.netlify.app/openshift-enterprise/latest/operators/operator_sdk/golang/osdk-golang-updating-projects#osdk-upgrading-projects_osdk-golang-updating-projects (step 2)

NOTE: {product-version} will render as 4.17 on the enterprise-4.17 branch when it is merged and published. It will show as Branch Build only during PR preview stage.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 21, 2024

🤖 Mon Oct 21 17:12:30 - Prow CI generated the docs preview:
https://83888--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2024
Copy link

openshift-ci bot commented Oct 21, 2024

@adellape: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 21, 2024
@michaelryanpeter
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 21, 2024
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion, but I am not sure if it is better than what you have originally. Also, it is another sub-bullet.

In the end, I think what you have makes sense given the constraints, so feel free to disregard if it isn't helpful.

+
--
* `config/default/manager_auth_proxy_patch.yaml`
* `bundle/manifests/memcached-operator.clusterserviceversion.yaml`
* `bundle/manifests/<operator_name>.clusterserviceversion.yaml` for your Operator project, for example `memcached-operator.clusterserviceversion.yaml` from the tutorials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `bundle/manifests/<operator_name>.clusterserviceversion.yaml` for your Operator project, for example `memcached-operator.clusterserviceversion.yaml` from the tutorials
* `bundle/manifests/<operator_name>.clusterserviceversion.yaml` for your Operator project
** For example, the `memcached-operator.clusterserviceversion.yaml` file from the tutorials

@michaelryanpeter
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants