-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enterprise-4.17] OCPBUGS#43395: Clarify ose-kube-rbac-proxy-rhel9 pull spec details #83888
base: enterprise-4.17
Are you sure you want to change the base?
Conversation
🤖 Mon Oct 21 17:12:30 - Prow CI generated the docs preview: |
@adellape: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a suggestion, but I am not sure if it is better than what you have originally. Also, it is another sub-bullet.
In the end, I think what you have makes sense given the constraints, so feel free to disregard if it isn't helpful.
+ | ||
-- | ||
* `config/default/manager_auth_proxy_patch.yaml` | ||
* `bundle/manifests/memcached-operator.clusterserviceversion.yaml` | ||
* `bundle/manifests/<operator_name>.clusterserviceversion.yaml` for your Operator project, for example `memcached-operator.clusterserviceversion.yaml` from the tutorials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `bundle/manifests/<operator_name>.clusterserviceversion.yaml` for your Operator project, for example `memcached-operator.clusterserviceversion.yaml` from the tutorials | |
* `bundle/manifests/<operator_name>.clusterserviceversion.yaml` for your Operator project | |
** For example, the `memcached-operator.clusterserviceversion.yaml` file from the tutorials |
/label peer-review-done |
https://issues.redhat.com/browse/OCPBUGS-43395
4.17
Follow-up to #83587 for clarity.
memcached-operator.clusterserviceversion.yaml
file unless they ran the tutorials, so clarify that they should look at whatever their project's file is calledPreview: https://83888--ocpdocs-pr.netlify.app/openshift-enterprise/latest/operators/operator_sdk/golang/osdk-golang-updating-projects#osdk-upgrading-projects_osdk-golang-updating-projects (step 2)
NOTE:
{product-version}
will render as4.17
on theenterprise-4.17
branch when it is merged and published. It will show asBranch Build
only during PR preview stage.