Allow specifying haproxy SSL Cipher list #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knobunc PTAL |
|
@pecameron @knobunc Is this PR to do with this trello card? It's moved to complete, but wondering if there's any docs efforts? If there's anything I can help with, please let me know, including this PR. |
Openshift 3.6 The user can select from among 3 predefined cipher lists: modern, intermediate, or old. Alternatively the use may provide a custom cipher list see "openssl ciphers". The list is used to negotiate a cipher between a user and haproxyi during bind. The predefined lists are from: https://wiki.mozilla.org/Security/Server_Side_TLS A new option to "oc adm router", --ciphers, is added to specify the cipher list. The values are modern|intermediate|old, or a ":" separated list of ciphers from "man 1 ciphers" Option --ciphers creates an environment variable, ROUTER_CIPHERS, which is passed to the router pod. ---------------------- General cleanup: "oadm router" changed to "oc adm router" Code changes are in: Openshift/origin PR 14505 openshift/origin#14505 Trello oeP7vrTZ https://trello.com/c/oeP7vrTZ/285-3-allow-modification-of-haproxys-ssl-cipher-preference-ingress
|
@bfallonf @ahardin-rh rebased. Is this ready to merge? |
|
Thanks @pecameron ! I'll merge this now and do a followup. I'll bug you if I have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openshift 3.6
The user can select from among 3 predefined cipher lists: modern,
intermediate, or old. Alternatively the use may provide a custom
cipher list see "openssl ciphers". The list is used to negotiate a
cipher between a user and haproxyi during bind.
The predefined lists are from:
https://wiki.mozilla.org/Security/Server_Side_TLS
A new option to "oc adm router", --ciphers, is added to specify
the cipher list. The values are modern|intermediate|old, or a
":" separated list of ciphers from "man 1 ciphers"
Option --ciphers creates an environment variable, ROUTER_CIPHERS,
which is passed to the router pod.
General cleanup: "oadm router" changed to "oc adm router"
Code changes are in:
Openshift/origin PR 14505
openshift/origin#14505
Trello oeP7vrTZ
https://trello.com/c/oeP7vrTZ/285-3-allow-modification-of-haproxys-ssl-cipher-preference-ingress