-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Opaque Integer Resources #19592
Conversation
The preview will be available shortly at: |
@sunilcio Is this a PR you can review? |
Files removed from 3.x via #19593 |
Anytime we remove or change a previously documented (and supported) feature we need to follow the steps outlined recently to help support these changes and help make the transition. We need acks from Product Experience, Docs, PM, Eng and QE. We also need to send out information about this change to openshift-sme and aos-devel, before we make this change, and once the change is done. @sferich888 and/or @reestr do you ack this change from both 3.11 and 4.x docs? @mburke5678 - Since eng raised this issue, happy to consider this as an ack. Not sure which PM can ack this change though. Can you confirm with eng? |
Based on kubernetes/enhancements#76 (comment) removing this from 3.10 and 3.11 docs should be OK, given that upstream kube dropped support for this resource in 1.9 (3.9) |
@tkatarki are you ok with us removing this from the docs for both 3.x and 4.x? |
@sunilcio Can you please review from QE? Thanks |
@weinliu PTAL |
Removing this is ok for QE as per:
|
@rphillips do you ack this change from both 3.11 and 4.x docs? |
@tkatarki @rphillips do you ack this change from both 3.11 and 4.x docs? |
@tkatarki Approved via Slack. |
/lgtm |
/cherrypick enterprise-4.1 |
@mburke5678: new pull request created: #20344 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.2 |
@mburke5678: new pull request created: #20345 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.3 |
@mburke5678: new pull request created: #20346 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.4 |
@mburke5678: new pull request created: #20347 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Per #19347
I see that Opaque Integer Resources are removed from 1.9 version as per the link here kubernetes/enhancements#76 (comment) so documentation related to Opaque Integer Resources should be removed.
Verified by @rphillips in Slack: https://coreos.slack.com/archives/CK1AE4ZCK/p1581020513181400