Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3.11 for openshift start / hyperkube changes #18691

Closed
wants to merge 1 commit into from
Closed

Update 3.11 for openshift start / hyperkube changes #18691

wants to merge 1 commit into from

Conversation

adellape
Copy link
Contributor

@adellape adellape commented Dec 17, 2019 •
edited
Loading

Fixes #11751.

Per https://github.com/openshift/origin/releases/tag/v3.11.0:

Preview (internal):

@adellape adellape added this to the Next Release milestone Dec 17, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2019
@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 17, 2019
@bergerhoffer bergerhoffer self-requested a review December 17, 2019 14:52
bergerhoffer
bergerhoffer reviewed Dec 17, 2019
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 17, 2019
@adellape
Copy link
Contributor Author

@deads2k PTAL wrt "Remove openshift start node and cut kubelet dependencies" openshift/origin#20344.

@vikram-redhat
Copy link
Contributor

@adellape can you try and push this to a merge?

@daliborfilus
Copy link

Documentation needs updating too - https://docs.okd.io/3.11/getting_started/administrators.html#getting-started-administrators

The documentation for 3.11 is no longer valid for 3.11.

@vikram-redhat
Copy link
Contributor

@adellape bump - can this be merged or closed? If you can merge and CP it by Monday, that will be great, otherwise, reopen against the enterprise-3.11 branch.

@adellape adellape mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

Assignees
No one assigned
Labels
branch/enterprise-3.11 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
5 participants
@adellape @vikram-redhat @daliborfilus @bergerhoffer @openshift-ci-robot