Removing openshift_repo dependencies. Moving to beginning of openshift_cluster.

[kwoodson]

No description provided.

[kwoodson]

@mtnbikenc, please take a look at this one. I am not as sure as to where to include openshift_repo but I chose the config.yml. Please let me know if you think this isn't a good place for this. I did complete a successful cluster install using this commit.

With these changes I was able to shave 1:28 off of an install. (37:51 down to 36:23). This is only about a 4.8% improvement with my 8 node cluster.

[mtnbikenc]

This change reduces the calls to openshift_repos during byo/config.yml from 41 to 1. With the other PR moving openshift_sanitize_inventory up, it would be a candidate to remove it from the openshift_repos dependencies. I will evaluate the other roles where openshift_repos has been removed and see if it affects any other execution paths for other entry point playbooks.

[kwoodson]

@mtnbikenc,

With the other PR moving openshift_sanitize_inventory up, it would be a candidate to remove it from the openshift_repos dependencies.

Agreed. Its going to get more difficult the longer we wait on merging other PRs into master

I will evaluate the other roles where openshift_repos has been removed and see if it affects any other execution paths for other entry point playbooks.

Thanks for doing this. I thought that the std_include.yml might be a good place for this if config.yml isn't the right place. Thoughts?

I was going to take a bit deeper dive today at this but figured your graphing tools would probably be much faster. Maybe I need a refresher on the graphing tools and I can attempt to assist with additions to that code. Let me know if you want to sync up via video conference or IRC.

[kwoodson]

@mtnbikenc, I'm moving the openshift_repos into the std_include.yml. This moves this role to the front initial setup of repositories since openshift_version requires repositories to be laid down.

I know we don't want std_include.yml expanded but the openshift_verion role depended on openshift_repos before so this shouldn't be any worse than before for std_include.yml. Now that the repositories have been initialized in the beginning we can remove their dependencies which is what the majority of this PR incorporates.

[kwoodson]

[test]

[sdodson]

travis errors and needs aos ci test once those are cleared

[kwoodson]

aos-ci-test

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_NOT_containerized for 6a46233 (logs)

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_containerized for 6a46233 (logs)

[kwoodson]

Rebased with master.

[kwoodson]

aos-ci-test

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_NOT_containerized for f88a203 (logs)

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_containerized for f88a203 (logs)

[mtnbikenc]

Needs Travis CI Ansible syntax errors fixed. It appears initialize_openshift_repos.yml was not included in the commit.

[kwoodson]

@mtnbikenc, good catch. I rebased and added the init repos file.

[kwoodson]

aos-ci-test

[mtnbikenc]

LGTM

[openshift-bot]

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for b376f0c (logs)

[openshift-bot]

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for b376f0c (logs)

[kwoodson]

flake
openshift/origin#8571
openshift/origin#10162

[kwoodson]

Looks like we need to rebase and run the gauntlet.

[sdodson]

Rebase and once aos-ci-test is done i'll merge this. I want to try to get all of this landed today.

[kwoodson]

aos-ci-test

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_NOT_containerized for 3b7e5d5 (logs)

[openshift-bot]

error: aos-ci-jenkins/OS_3.6_containerized for 3b7e5d5 (logs)

[mtnbikenc]

Flake openshift/origin#14898 yum repo

[mtnbikenc]

[merge]

[kwoodson]

flake
openshift/origin#8571

[kwoodson]

[merge]

[mtnbikenc]

@kwoodson Somehow initialize_openshift_repos.yml was dropped from the commits during the last rebase.

[mtnbikenc]

Need to add initialize_openshift_repos.yml to pass tox tests.

[kwoodson]

@mtnbikenc, thanks for watching this one. I'm not sure what happened but I added the file again.

[kwoodson]

aos-ci-test

[openshift-bot]

Evaluated for openshift ansible merge up to 94c195b

[openshift-bot]

Evaluated for openshift ansible test up to 94c195b

[openshift-bot]

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 94c195b (logs)

[openshift-bot]

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 94c195b (logs)

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/446/) (Base Commit: fa32667) (PR Branch Commit: 94c195b)

[kwoodson]

@sosiouxme @rhcarvalho, @sdodson

Any idea what happened here?

		Failure summary:
		
		  1. Host:     openshift_ansible_test_3869285588729
		     Play:     Initialize host firewall
		     Task:     os_firewall : Ensure firewalld service is not enabled
		     Message:  Failed to get D-Bus connection: Operation not permitted

[openshift-bot]

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/854/) (Base Commit: 2bc6832) (PR Branch Commit: 94c195b)

[sosiouxme]

@kwoodson no, but it's happening quite a lot :(
openshift/origin#15769

[ingvagabund]

Aweeeeeesooome, thanks @kwoodson