Containerized installs on RHEL were downgrading docker unnecessarily #1718

brenton · 2016-04-06T16:18:43Z

No description provided.

brenton · 2016-04-06T16:20:46Z

roles/docker/tasks/main.yml

@@ -10,7 +10,12 @@
 - name: Downgrade docker if necessary
  command: "{{ ansible_pkg_mgr }} downgrade -y docker-{{ docker_version }}"
  register: docker_downgrade_result
-  when: not docker_version_result | skipped and docker_version_result | default('0.0', True) | version_compare(docker_version, 'gt')
+  when: not docker_version_result | skipped and docker_version_result.stdout | default('0.0', True) | version_compare(docker_version, 'gt')


@sdodson, I think not using .stdout was just a bug previously.

brenton · 2016-04-06T16:25:57Z

aos-ci-test

detiber · 2016-04-06T16:30:07Z

roles/openshift_docker_facts/tasks/main.yml

+
+- set_fact:
+    l_common_version: "{{ common_version.stdout | default('0.0', True) }}"
+  when: not openshift.common.is_containerized | bool


I probably have an irrational hate of set_fact... I can't think of a way to put this into a vars file though, with the use of common_version.stdout though...

it could be limited down to one set_fact if you do the following though:

l_common_version: "{{ ( openshift.common.image_tag | oo_image_tag_to_rpm_version if openshift.common.is_containerized | bool else common_version.stdout) | default('0.0', True) }}"

I'd do whatever you prefer. I sort of hate inlining if/else like this. It almost always gets more complicated and I can no longer count how many bugs I've seen because of followup edits that subtly break things.

That's fine, if it can't be eliminated by pushing it to vars, it's not really worth it anyway.

brenton · 2016-04-06T18:30:25Z

roles/openshift_examples/files/examples/v1.2/xpaas-streams/jboss-image-streams.json

-                          "Kind": "DockerImage",
-                          "Name": "registry.access.redhat.com/jboss-eap-7-beta/eap70-openshift:1.3"
+                          "kind": "DockerImage",
+                          "name": "registry.access.redhat.com/jboss-eap-7-beta/eap70-openshift:1.3"
                        }


@sdodson, I think the reason these passed testing is because they ran against 3.0 and 3.1. It looks like for 3.2 it breaks validation.

crap, yeah. filed an issue with upstream of us so we don't inadvertantly re-introduce this jboss-openshift/application-templates#144

no worries, I figured I'd bundle it in with some PR like this one.

brenton · 2016-04-06T18:38:05Z

aos-ci-test

arilivigni · 2016-04-06T19:53:12Z

aos-ci-test

brenton · 2016-04-06T21:03:59Z

roles/docker/tasks/main.yml

-  action: "{{ ansible_pkg_mgr }} name=docker{{ '-' + docker_version if docker_version != '' else '' }} state=present"
-  when: not openshift.common.is_atomic | bool and not docker_downgrade_result | changed
+  action: "{{ ansible_pkg_mgr }} name=docker{{ '-' + docker_version if docker_version_result.stdout == '' }} state=latest"
+  when: not openshift.common.is_atomic | bool and not docker_version_result | skipped and docker_version_result.stdout | default('0.0', True) | version_compare(docker_version, 'lt')


@detiber, @sdodson, this is what I'm testing. It's weird but it seems to handle the 1) no docker installed 2) downgrade and 3) upgrade cases. The idea is that if docker_version_result.stdout is empty we need to install the minimum required version. If there is a version installed and we didn't need to downgrade then we can ensure the latest version.

I think there's still an edgecase if a version like 1.8.1 was installed and we needed 1.8.2. I think it would actually result in 1.9.1 being installed. This is a mess.

Did it not work without changing from if docker_version != '' to docker_version_result.stdout == '' As you have it we'd always need to set docker_version, which would be the case if we changed from > 3.2/1.2 to >= 3.2/1.2 in the facts.

Nevermind, I see you're accounting for that in the when condition.

I'm actually surprised there isn't an error for line 16 and not having a else clause... I suppose that is just a jinja2'ism.

Again, I really think we should avoid latest to avoid upgrading docker inadvertently during regular CM operations, since we should only have to worry about initial installation, and 1.2/3.2 packages would have a requirement on docker-1.9, that should only leave us with issues related to containerized installs and docker versions.

I'm fine with reworking this to avoid using 'latest'. I think one of the problems I was hitting was coming up with some simple logic without reworking what we already had too much. I think if we don't have 'latest' the way the logic is now it could result in docker-1.9.1 being explicitly installed even though a 1.9.2 package was available. That isn't the end of the world but it's a spell of overly complicated logic.

I've posted this[0] question regarding how we should express requirements of the host os. If we're not worried about containerized installs this is a non issue because installing 3.2 atomic-openshift-node package will ensure that we're at a minimum version so it's really the upper version limits for 3.1 and 3.0 that we require.

0 - http://ask.projectatomic.io/en/question/3641/expressing-requirements-of-the-host-os/

brenton · 2016-04-07T21:00:42Z

roles/docker/tasks/main.yml

+- name: Remove deferred deletion for downgrades from 1.9
+  command: >
+    sed -i 's/--storage-opt dm.use_deferred_deletion=true//' /etc/sysconfig/docker-storage
+  when: docker_version_result.stdout | default('0.0', True) | version_compare('1.9', '>=') and docker_version | version_compare('1.9', '<')


@sdodson, what do you think about this?

brenton · 2016-04-07T21:01:01Z

aos-ci-test

brenton · 2016-04-07T21:04:05Z

roles/docker/tasks/main.yml

+- name: Remove deferred deletion for downgrades from 1.9
+  command: >
+    sed -i 's/--storage-opt dm.use_deferred_deletion=true//' /etc/sysconfig/docker-storage
+  when: not docker_version_result | skipped and docker_version_result.stdout | default('0.0', True) | version_compare('1.9', '>=') and docker_version | version_compare('1.9', '<')


@sdodson, I just made another update to add not docker_version_result | skipped.

Maybe it's just github but it looks like you didn't remove the old version of this from below? We also need the check for the file existence moved above this, i'd drop its when clause all together.

Because the file may not exist if they haven't started docker before.

- stat: path=/etc/sysconfig/docker register: docker_check

brenton · 2016-04-07T21:04:18Z

aos-ci-test

brenton · 2016-04-08T17:32:06Z

aos-ci-test

detiber · 2016-04-08T18:44:22Z

lgtm

brenton · 2016-04-08T20:57:32Z

roles/docker/tasks/main.yml

-  action: "{{ ansible_pkg_mgr }} name=docker{{ '-' + docker_version if docker_version != '' else '' }} state=present"
-  when: not openshift.common.is_atomic | bool and not docker_downgrade_result | changed
+  action: "{{ ansible_pkg_mgr }} name=docker{{ '-' + docker_version if docker_version_result.stdout == '' }} state=present"
+  when: not openshift.common.is_atomic | bool and not docker_version_result | skipped and docker_version_result.stdout | default('0.0', True) | version_compare(docker_version, 'lt')


@detiber, @abutcher do you have any idea how this line could result in this error?

One or more undefined variables: the inline if-expression on line 1 evaluated to false and no else section was defined.

This showed that all the variables were actually defined as expected:

- debug: var=openshift - debug: var=docker_version_result - debug: var=docker_version

@brenton maybe stdout is not in docker_version_result?

Line above it is missing an else

{{ '-' + docker_version if docker_version_result.stdout == '' else '' }}

From the logs I have it is:

2016-04-08 16:51:21,001 p=924 u=root | ok: [ip-172-18-0-28.ec2.internal] => { "var": { "docker_version_result": { "changed": false, "cmd": [ "repoquery", "--installed", "--qf", "%{version}", "docker" ], ** SNIP** "start": "2016-04-08 16:51:19.957724", "stderr": "", "stdout": "1.8.2", "stdout_lines": [ "1.8.2" ], "warnings": [] } } } 2016-04-08 16:51:21,003 p=924 u=root | ok: [ip-172-18-15-36.ec2.internal] => { "var": { "docker_version_result": { "changed": false, **SNIP** "rc": 0, "start": "2016-04-08 16:51:20.019622", "stderr": "", "stdout": "1.8.2", "stdout_lines": [ "1.8.2" ], "warnings": [] } } }

@abutcher, yeah, that was it. :(

@detiber, this is pretty hard to read but here's the thinking:

If docker_version_result.stdout == '' that means docker was never installed. Therefore we have to rely on the docker_version and result in something like yum install docker-1.8.2. If there is stdout that means it's installed. We've already previously downgraded to the correct version in the previous step. So really we just have to make sure the package is installed to skip that test. I'll be honest, I would have expected the 'when' clause to prevent that logic from ever running.

There's gaps in this that have been identified since I did the backport but should we try to be less clever for the sake of clarity? I liked how easy this was to follow in my backport

openshift-ansible/roles/docker/tasks/main.yml

Lines 10 to 65 in 7e39163

# Avoid docker 1.9 when installing origin < 1.2 or OSE < 3.2 on RHEL/Centos and

# See: https://bugzilla.redhat.com/show_bug.cgi?id=1304038

- name: Default to latest docker

set_fact:

docker_version: ''

docker_downgrade: False

- name: Gather installed version of common package

shell: >

rpm -q {{ openshift.common.service_type }} --queryformat '%{version}' | cut -d '.' -f1,2 | grep -v 'not installed'

register: installed_common_version

failed_when: false

changed_when: false

- name: Gather available version of common package

shell: >

yum list available -e 0 -q "{{ openshift.common.service_type}}" 2>&1 | tail -n +2 | awk '{ print $2 }' | sort -r | tr '\n' ' ' | tail -n 1 | cut -d '.' -f1,2

register: available_common_version

failed_when: false

changed_when: false

- name: Gather installed version of docker

shell: >

rpm -q docker --queryformat '%{version}' | cut -d '.' -f1,2 | grep -v 'not installed'

register: installed_docker_version

failed_when: false

changed_when: false

- name: Gather available version of docker

shell: >

yum list available -e 0 -q "docker" 2>&1 | tail -n +2 | awk '{ print $2 }' | sort -r | tr '\n' ' ' | tail -n 1

register: available_docker_version

failed_when: false

changed_when: false

- set_fact:

docker_version: "{{ '1.8.2' }}"

when: " installed_common_version.stdout in ['3.0','3.1','1.0','1.1'] or available_common_version.stdout in ['3.0','3.1','1.0','1.1']"

- set_fact:

docker_downgrade: True

when: " docker_version < installed_docker_version.stdout and docker_version != ''"

- name: Remove deferred removal and deletion for 1.8.2 downgrades

command: >

sed -i 's/--storage-opt dm.use_deferred_deletion=true//' /etc/sysconfig/docker-storage

when: docker_downgrade | bool and docker_version == '1.8.2'

- name: Downgrade docker

command: >

{{ ansible_pkg_mgr }} downgrade -y docker{{ '-' + docker_version if docker_version != '' else '' }}

when: not openshift.common.is_atomic and docker_downgrade | bool

- name: Install docker

action: "{{ ansible_pkg_mgr }} name=docker{{ '-' + docker_version if docker_version != '' else '' }} state=present"

when: not openshift.common.is_atomic | bool and not docker_downgrade | bool

It's getting late on a Friday. I'm honestly struggling to see how either of these are easy to follow given all the logic branches for containerized installs.

So, I didn't test with Docker not installed, but with the current logic it failed for the upgrade scenario

detiber · 2016-04-08T22:57:11Z

action: "{{ ansible_pkg_mgr }} name=docker{{ '-' + docker_version if docker_version != '' else '' }} state=present"

I think the conditional in the action needs to use Docker_version and not Docker_version_result.

brenton · 2016-04-08T23:21:34Z

@detiber, I don't think that handles the case of docker not being installed. I'll have to check though.

openshift-bot · 2016-04-12T18:34:45Z

dc2a6e9 - State: error - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized - Test Description: Internal Jenkins error during provisioning an 3.1 cluster - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-provision-ose-cluster-728/dc2a6e9a25edbe1fa3ba8324e22f6fcf709a6de7.txt

openshift-bot · 2016-04-12T18:36:05Z

dff69c8 - State: success - Test Context: aos-ci-jenkins/OS_unit_tests - Test Description: all unit tests passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-pre-test-386/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

openshift-bot · 2016-04-12T18:38:45Z

dff69c8 - State: error - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized - Test Description: Internal Jenkins error during provisioning an 3.1 cluster - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-provision-ose-cluster-731/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

openshift-bot · 2016-04-12T18:38:45Z

dff69c8 - State: error - Test Context: aos-ci-jenkins/OS_3.0_NOT_containerized - Test Description: Internal Jenkins error during provisioning an 3.0 cluster - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-provision-ose-cluster-729/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

openshift-bot · 2016-04-12T18:38:45Z

dff69c8 - State: error - Test Context: aos-ci-jenkins/OS_3.1_containerized - Test Description: Internal Jenkins error during provisioning an 3.1 cluster - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-provision-ose-cluster-730/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

arilivigni · 2016-04-12T18:44:37Z

aos-ci-test

openshift-bot · 2016-04-12T18:46:58Z

dff69c8 - State: success - Test Context: aos-ci-jenkins/OS_unit_tests - Test Description: all unit tests passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-pre-test-387/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

… containerized env

brenton · 2016-04-12T20:23:44Z

aos-ci-test

openshift-bot · 2016-04-12T20:25:57Z

0879620 - State: success - Test Context: aos-ci-jenkins/OS_unit_tests - Test Description: all unit tests passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-pre-test-388/0879620498b1251f3a375b9a5657c16dd571906a.txt

openshift-bot · 2016-04-12T20:52:48Z

45a4e6e - State: error - Test Context: aos-ci-jenkins/OS_3.1_containerized - Test Description: openshift-ansible install failed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-616/45a4e6e468fd0f60c595503d55d155c82a2289ca.txt

openshift-bot · 2016-04-12T20:52:48Z

45a4e6e - State: success - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-617/45a4e6e468fd0f60c595503d55d155c82a2289ca.txt

openshift-bot · 2016-04-12T20:52:48Z

94416d5 - State: success - Test Context: aos-ci-jenkins/OS_3.0_NOT_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-618/94416d577a355eae25c8e71a283fc0f8ed2b34af.txt

openshift-bot · 2016-04-12T20:53:17Z

45a4e6e - State: error - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized_e2e_tests - Test Description: all e2e tests failed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-e2e-tests-149/45a4e6e468fd0f60c595503d55d155c82a2289ca.txt

openshift-bot · 2016-04-12T20:54:46Z

94416d5 - State: error - Test Context: aos-ci-jenkins/OS_3.1_containerized - Test Description: openshift-ansible install failed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-619/94416d577a355eae25c8e71a283fc0f8ed2b34af.txt

openshift-bot · 2016-04-12T20:54:46Z

dff69c8 - State: success - Test Context: aos-ci-jenkins/OS_3.1_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-621/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

openshift-bot · 2016-04-12T20:54:46Z

dff69c8 - State: success - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-622/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

openshift-bot · 2016-04-12T20:54:46Z

94416d5 - State: success - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-620/94416d577a355eae25c8e71a283fc0f8ed2b34af.txt

openshift-bot · 2016-04-12T20:54:46Z

dff69c8 - State: success - Test Context: aos-ci-jenkins/OS_3.0_NOT_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-623/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

openshift-bot · 2016-04-12T20:54:47Z

0879620 - State: success - Test Context: aos-ci-jenkins/OS_3.0_NOT_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-624/0879620498b1251f3a375b9a5657c16dd571906a.txt

openshift-bot · 2016-04-12T20:54:47Z

0879620 - State: success - Test Context: aos-ci-jenkins/OS_3.1_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-625/0879620498b1251f3a375b9a5657c16dd571906a.txt

openshift-bot · 2016-04-12T20:55:27Z

94416d5 - State: error - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized_e2e_tests - Test Description: all e2e tests failed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-e2e-tests-150/94416d577a355eae25c8e71a283fc0f8ed2b34af.txt

openshift-bot · 2016-04-12T20:58:58Z

dff69c8 - State: success - Test Context: aos-ci-jenkins/OS_3.1_containerized_e2e_tests - Test Description: all e2e tests passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-e2e-tests-151/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

openshift-bot · 2016-04-12T20:59:12Z

dff69c8 - State: success - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized_e2e_tests - Test Description: all e2e tests passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-e2e-tests-152/dff69c863c71d9a4c1e41a2908f87bfce1c1fa15.txt

openshift-bot · 2016-04-12T20:59:28Z

0879620 - State: success - Test Context: aos-ci-jenkins/OS_3.1_containerized_e2e_tests - Test Description: all e2e tests passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-e2e-tests-153/0879620498b1251f3a375b9a5657c16dd571906a.txt

openshift-bot · 2016-04-12T20:59:57Z

0879620 - State: success - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized - Test Description: openshift-ansible install passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-openshift-ansible-626/0879620498b1251f3a375b9a5657c16dd571906a.txt

openshift-bot · 2016-04-12T21:04:58Z

0879620 - State: success - Test Context: aos-ci-jenkins/OS_3.1_NOT_containerized_e2e_tests - Test Description: all e2e tests passed - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-run-e2e-tests-154/0879620498b1251f3a375b9a5657c16dd571906a.txt

brenton · 2016-04-12T21:06:53Z

All 7 ci jobs are passing and I did a ton of manual testing today. I'm merging this to unblock a lot of other testing.

brenton force-pushed the docker1 branch from 4b0afd6 to a838c36 Compare April 6, 2016 16:20

brenton reviewed Apr 6, 2016
View reviewed changes

brenton force-pushed the docker1 branch from a838c36 to a2b64fd Compare April 6, 2016 16:25

abutcher mentioned this pull request Apr 6, 2016

Test docker_version_result.stdout when determining if docker should be installed/downgraded. #1720

Merged

detiber reviewed Apr 6, 2016
View reviewed changes

brenton force-pushed the docker1 branch 2 times, most recently from e62ae2a to cc49a45 Compare April 6, 2016 18:28

brenton reviewed Apr 6, 2016
View reviewed changes

brenton force-pushed the docker1 branch from cc49a45 to 124e7ce Compare April 6, 2016 19:22

brenton force-pushed the docker1 branch from 124e7ce to 6dbdf09 Compare April 6, 2016 20:56

brenton reviewed Apr 6, 2016
View reviewed changes

brenton force-pushed the docker1 branch from 6dbdf09 to a757ce0 Compare April 7, 2016 21:00

brenton reviewed Apr 7, 2016
View reviewed changes

brenton force-pushed the docker1 branch from a757ce0 to dca9b76 Compare April 7, 2016 21:02

brenton reviewed Apr 7, 2016
View reviewed changes

brenton force-pushed the docker1 branch from dca9b76 to 04baad3 Compare April 8, 2016 17:31

brenton reviewed Apr 8, 2016
View reviewed changes

brenton force-pushed the docker1 branch from 04baad3 to 67c6fc2 Compare April 8, 2016 23:19

Bug 1324728 - Ansible should not downgrade docker when installing 3.2…

0879620

… containerized env

brenton force-pushed the docker1 branch from dff69c8 to 0879620 Compare April 12, 2016 20:09

brenton merged commit 7967d12 into openshift:master Apr 12, 2016

	# Avoid docker 1.9 when installing origin < 1.2 or OSE < 3.2 on RHEL/Centos and
	# See: https://bugzilla.redhat.com/show_bug.cgi?id=1304038
	- name: Default to latest docker
	set_fact:
	docker_version: ''
	docker_downgrade: False

	- name: Gather installed version of common package
	shell: >
	rpm -q {{ openshift.common.service_type }} --queryformat '%{version}' \| cut -d '.' -f1,2 \| grep -v 'not installed'
	register: installed_common_version
	failed_when: false
	changed_when: false

	- name: Gather available version of common package
	shell: >
	yum list available -e 0 -q "{{ openshift.common.service_type}}" 2>&1 \| tail -n +2 \| awk '{ print $2 }' \| sort -r \| tr '\n' ' ' \| tail -n 1 \| cut -d '.' -f1,2
	register: available_common_version
	failed_when: false
	changed_when: false

	- name: Gather installed version of docker
	shell: >
	rpm -q docker --queryformat '%{version}' \| cut -d '.' -f1,2 \| grep -v 'not installed'
	register: installed_docker_version
	failed_when: false
	changed_when: false

	- name: Gather available version of docker
	shell: >
	yum list available -e 0 -q "docker" 2>&1 \| tail -n +2 \| awk '{ print $2 }' \| sort -r \| tr '\n' ' ' \| tail -n 1
	register: available_docker_version
	failed_when: false
	changed_when: false

	- set_fact:
	docker_version: "{{ '1.8.2' }}"
	when: " installed_common_version.stdout in ['3.0','3.1','1.0','1.1'] or available_common_version.stdout in ['3.0','3.1','1.0','1.1']"

	- set_fact:
	docker_downgrade: True
	when: " docker_version < installed_docker_version.stdout and docker_version != ''"

	- name: Remove deferred removal and deletion for 1.8.2 downgrades
	command: >
	sed -i 's/--storage-opt dm.use_deferred_deletion=true//' /etc/sysconfig/docker-storage
	when: docker_downgrade \| bool and docker_version == '1.8.2'

	- name: Downgrade docker
	command: >
	{{ ansible_pkg_mgr }} downgrade -y docker{{ '-' + docker_version if docker_version != '' else '' }}
	when: not openshift.common.is_atomic and docker_downgrade \| bool

	- name: Install docker
	action: "{{ ansible_pkg_mgr }} name=docker{{ '-' + docker_version if docker_version != '' else '' }} state=present"
	when: not openshift.common.is_atomic \| bool and not docker_downgrade \| bool

Containerized installs on RHEL were downgrading docker unnecessarily #1718

Containerized installs on RHEL were downgrading docker unnecessarily #1718

Conversation

brenton commented Apr 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brenton commented Apr 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brenton commented Apr 6, 2016

arilivigni commented Apr 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brenton commented Apr 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brenton commented Apr 7, 2016

brenton commented Apr 8, 2016

detiber commented Apr 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

detiber commented Apr 8, 2016

brenton commented Apr 8, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

arilivigni commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

brenton commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

openshift-bot commented Apr 12, 2016

brenton commented Apr 12, 2016